Re: [PATCH, v2] kbuild: Improve version string logic

Ingo Molnar
2009-10-13T07:06:01Z

* Frans Pop <elendil@planet.nl> wrote:

> On Monday 12 October 2009, Ingo Molnar wrote:
> > It changes how CONFIG_LOCALVERSION_AUTO works, in the following trivial
> > way:
> >
> >  - if it is set, things work the way they always have, and you get a
> >    extended kernel release like:
> >
> >         2.6.32-rc3-00052-g0eca52a
> >
> >  - but if it is _not_ set, we'll still try to get a version from the
> >    underlying SCM (we actually support git, hg and SVN right now, even
> > if some comments may say "git only"), and if the underlying SCM says it
> > has a local version, we append just "+", so you get a version number
> > like:
> >
> >         2.6.32-rc3+
>
> I don't object to making this the default (even a strong default), but
> I still don't like the fact that it's not optional.
>
> IMO both LOCALVERSION_AUTO *and* the added "+" can be unsuitable for
> some use cases, for example for distributions.
>
> If someone uses git to manage their custom patches, the only out this
> patch leaves them to avoid the "+" is to revert it in their own trees.

Is this a bad thing?

> IMO that should not be necessary.

Why not?

Ingo