Re: [patch] kbuild: Improve version string logic

Johannes Berg
2009-10-06T19:50:01Z

[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]

On Tue, 2009-10-06 at 21:45 +0200, Frans Pop wrote:
> Johannes Berg wrote:
> > I think adding the + unconditionally will also break things like
> > debian's make-kpkg, for instance, since the + would get propagated into
> > the package version which reserves the + for something else.
>
> Are you sure?

No, I'm not.

> AFAIK it would be propagated into the package _name_, where
> it is allowed. And even if it were part of the package version, it would
> be in the "upstream" part of the version number, where it is also allowed.
>
> The only reserved use of "+" I'm aware of is in the Debian part of the
> package version.
>
> But I have not used make-kpkg in ages, so I'm not 100% sure how that builds
> the package version. I could be that it duplicates the kernel version in
> both the package name and the upstream part of the package version, but
> that should still be OK.

That may all well be true. I wasn't even aware of the distinction
between debian and upstream part of the version :)

I do, however, remember no end to trouble with autoversion and make-kpkg
so eventually gave up on using it entirely.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]