From: Linus Torvalds <torvalds@linux-foundation.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
David Miller <davem@davemloft.net>,
linville@tuxdriver.com, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: Please consider reverting 7d930bc33653d5592dc386a76a38f39c2e962344
Date: Tue, 3 Nov 2009 07:31:06 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.01.0911030726420.31845@localhost.localdomain> (raw)
In-Reply-To: <1257234299.28469.25.camel@johannes.local>
On Tue, 3 Nov 2009, Johannes Berg wrote:
>
> I'll rant a bit too -- I've been very annoyed by this many times. Note
> this isn't really against you (Dmitry) in particular, just another
> case ... but it does tick me off that many times when somebody manages
> to blame a failure on a specific commit the first thing they do is ask
> somebody way "above" (in terms of patch flow into mainline) the person
> writing the patch (like Linus here) to revert it.
Johannes, you're simply WRONG.
At this point (ie _way_ after -rc1), "just revert it" really is the right
thing to do. The commit was shit. It caused more problems than it fixed. I
should have reverted it immediately when that was clear. I didn't, and
because I didn't, other people then had to waste time bisecting it.
So instead of complaining about other people, I would suggest you look
yourself in the mirror. Stop thinking you "own" code. If you wrote a buggy
commit, and somebody else went through the work to bisect it, you should
(a) expect it to be reverted
(b) thank the person for finding the bug YOU introduced.
(c) be ashamed of YOURSELF
instead of whining about it as if we should thank you!
Linus
next prev parent reply other threads:[~2009-11-03 15:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 5:31 Please consider reverting 7d930bc33653d5592dc386a76a38f39c2e962344 Dmitry Torokhov
2009-11-03 6:49 ` David Miller
2009-11-03 6:52 ` Dmitry Torokhov
2009-11-03 7:16 ` Marcel Holtmann
2009-11-03 7:44 ` Johannes Berg
2009-11-03 8:22 ` Dmitry Torokhov
2009-11-03 8:31 ` Johannes Berg
2009-11-03 8:47 ` Dmitry Torokhov
2009-11-03 8:57 ` Johannes Berg
2009-11-03 15:29 ` Marcel Holtmann
2009-11-03 15:38 ` Linus Torvalds
2009-11-05 19:19 ` Pavel Machek
2009-11-03 15:31 ` Linus Torvalds [this message]
2009-11-04 6:34 ` Andrew Morton
2009-11-04 8:41 ` David Miller
2009-11-04 15:23 ` Andrew Morton
2009-11-04 16:32 ` David Miller
2009-11-03 15:26 ` Linus Torvalds
2009-11-03 15:36 ` Marcel Holtmann
2009-11-03 15:43 ` Linus Torvalds
2009-11-03 16:07 ` Linus Torvalds
2009-11-03 16:08 ` Marcel Holtmann
2009-11-03 16:23 ` Linus Torvalds
2009-11-03 16:37 ` Linus Torvalds
2009-11-03 16:44 ` Marcel Holtmann
2009-11-03 16:59 ` Linus Torvalds
2009-11-03 16:29 ` Ingo Molnar
2009-11-03 16:49 ` Marcel Holtmann
2009-11-03 17:04 ` Ingo Molnar
2009-11-03 17:24 ` Luis R. Rodriguez
2009-11-03 17:37 ` Linus Torvalds
2009-11-03 17:49 ` Dmitry Torokhov
2009-11-03 17:55 ` Luis R. Rodriguez
2009-11-03 15:54 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0911030726420.31845@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox