From: Linus Torvalds <torvalds@linux-foundation.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
David Miller <davem@davemloft.net>,
johannes@sipsolutions.net, linville@tuxdriver.com,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: Please consider reverting 7d930bc33653d5592dc386a76a38f39c2e962344
Date: Tue, 3 Nov 2009 08:59:36 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.01.0911030851440.31845@localhost.localdomain> (raw)
In-Reply-To: <1257266647.3420.105.camel@localhost.localdomain>
On Wed, 4 Nov 2009, Marcel Holtmann wrote:
>
> However to be fair here, this one didn't hit everybody. I for myself
> haven't seen it at all and actually I have been running this "faulty"
> kernel for a while now and suspending happily multiple times a day. As
> much as you hate that the patch for this bug took longer than needed to
> find its way into your tree, the immediate need and the wide problem was
> not clear.
I do not agree.
A _single_ NULL pointer report should have made it clear. As mentioned, I
was involved in one of the "please revert" threads, and I looked at the
code, and it was obviously bogus. I could (and did) point to the exact
memcpy() that caused the problem.
There really was no excuse. That 7d930bc33 commit had a NULL pointer
dereference, and people hit it. End of story.
The fact that not _all_ people hit it explains how it got pulled into my
tree in the first place, but that's it.
Linus
next prev parent reply other threads:[~2009-11-03 17:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 5:31 Please consider reverting 7d930bc33653d5592dc386a76a38f39c2e962344 Dmitry Torokhov
2009-11-03 6:49 ` David Miller
2009-11-03 6:52 ` Dmitry Torokhov
2009-11-03 7:16 ` Marcel Holtmann
2009-11-03 7:44 ` Johannes Berg
2009-11-03 8:22 ` Dmitry Torokhov
2009-11-03 8:31 ` Johannes Berg
2009-11-03 8:47 ` Dmitry Torokhov
2009-11-03 8:57 ` Johannes Berg
2009-11-03 15:29 ` Marcel Holtmann
2009-11-03 15:38 ` Linus Torvalds
2009-11-05 19:19 ` Pavel Machek
2009-11-03 15:31 ` Linus Torvalds
2009-11-04 6:34 ` Andrew Morton
2009-11-04 8:41 ` David Miller
2009-11-04 15:23 ` Andrew Morton
2009-11-04 16:32 ` David Miller
2009-11-03 15:26 ` Linus Torvalds
2009-11-03 15:36 ` Marcel Holtmann
2009-11-03 15:43 ` Linus Torvalds
2009-11-03 16:07 ` Linus Torvalds
2009-11-03 16:08 ` Marcel Holtmann
2009-11-03 16:23 ` Linus Torvalds
2009-11-03 16:37 ` Linus Torvalds
2009-11-03 16:44 ` Marcel Holtmann
2009-11-03 16:59 ` Linus Torvalds [this message]
2009-11-03 16:29 ` Ingo Molnar
2009-11-03 16:49 ` Marcel Holtmann
2009-11-03 17:04 ` Ingo Molnar
2009-11-03 17:24 ` Luis R. Rodriguez
2009-11-03 17:37 ` Linus Torvalds
2009-11-03 17:49 ` Dmitry Torokhov
2009-11-03 17:55 ` Luis R. Rodriguez
2009-11-03 15:54 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0911030851440.31845@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox