From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758765AbZKKU0q (ORCPT ); Wed, 11 Nov 2009 15:26:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758348AbZKKU0q (ORCPT ); Wed, 11 Nov 2009 15:26:46 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:34648 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbZKKU0p (ORCPT ); Wed, 11 Nov 2009 15:26:45 -0500 Date: Wed, 11 Nov 2009 12:25:54 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Marcel Holtmann cc: "Rafael J. Wysocki" , Thomas Gleixner , Mike Galbraith , Ingo Molnar , LKML , pm list , Greg KH , Jesse Barnes , Tejun Heo , Oleg Nesterov , Oliver Neukum , linux-bluetooth@vger.kernel.org Subject: Re: GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd) In-Reply-To: <1257970719.21467.4.camel@violet> Message-ID: References: <200911091250.31626.rjw@sisk.pl> <200911100119.38019.rjw@sisk.pl> <200911111252.48214.rjw@sisk.pl> <1257970719.21467.4.camel@violet> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Nov 2009, Marcel Holtmann wrote: > > As it seems the btusb_close() only cancels the work workqueue and not > the waker workqueue. Could that be the problem. It's the waker workqueue that Rafael apparently sees with the debug patch from Oleg, so yeah, that sounds possible. Rafael, since apparently htusb_close() _is_ called, does the following simpler patch fix it for you? I bet your patch does it too. Linus --- drivers/bluetooth/btusb.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 7ba91aa..2fb3802 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -591,6 +591,7 @@ static int btusb_close(struct hci_dev *hdev) return 0; cancel_work_sync(&data->work); + cancel_work_sync(&data->waker); clear_bit(BTUSB_ISOC_RUNNING, &data->flags); clear_bit(BTUSB_BULK_RUNNING, &data->flags);