From: Thomas Gleixner <tglx@linutronix.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>, Ingo Molnar <mingo@elte.hu>,
Ben Greear <greearb@candelatech.com>,
stable@kernel.org
Subject: Re: [patch 1/3] rtc: Handle errors correctly in rtc_irq_set_state()
Date: Sat, 23 Jul 2011 09:15:54 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1107230907440.2702@ionos> (raw)
In-Reply-To: <20110722150432.2370bcf2.akpm@linux-foundation.org>
On Fri, 22 Jul 2011, Andrew Morton wrote:
> On Fri, 22 Jul 2011 09:12:50 -0000
> Thomas Gleixner <tglx@linutronix.de> wrote:
>
> > The code checks the correctness of the parameters, but unconditionally
> > arms/disarms the hrtimer.
> >
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > Cc: stable@kernel.org
>
> The -stable maintainers will want to know why they should merge this.
>
> The maintainers of other trees will wonder whether they should backport
> it too.
>
> To help them make these decision we should always provide a description
> of the user-visible effects of the bug, please.
Fair enough.
The result is that a random task might arm/disarm rtc timer and
surprise the real owner by either generating events or by stopping
them. Both undesired behaviour :)
next prev parent reply other threads:[~2011-07-23 7:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 9:12 [patch 0/3] rtc: Assorted bug fixes Thomas Gleixner
2011-07-22 9:12 ` [patch 1/3] rtc: Handle errors correctly in rtc_irq_set_state() Thomas Gleixner
2011-07-22 22:04 ` Andrew Morton
2011-07-23 7:15 ` Thomas Gleixner [this message]
2011-07-22 9:12 ` [patch 3/3] rtc: Limit frequency Thomas Gleixner
2011-07-22 22:05 ` Andrew Morton
2011-07-22 22:39 ` [stable] " Willy Tarreau
2011-08-05 3:39 ` Joshua Kinard
2011-08-05 9:04 ` John Stultz
2011-08-06 7:28 ` Joshua Kinard
2011-07-23 7:17 ` Thomas Gleixner
2011-07-22 9:12 ` [patch 2/3] rtc: Fix hrtimer deadlock Thomas Gleixner
2011-07-22 22:11 ` Andrew Morton
2011-07-23 7:22 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1107230907440.2702@ionos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=greearb@candelatech.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox