Re: [PATCH 61/62] Documentation: irq: Change documents related to IRQF_DISABLED

Yong Zhang
2011-09-09T01:38:29Z

On Thu, Sep 08, 2011 at 02:38:33PM -0700, Randy Dunlap wrote:
> On 09/07/11 01:10, Yong Zhang wrote:
> > IRQF_DISABLED is a NOOP now, place where suggest to use this
> > flag also doesn't make sense anymore.
> >
> > Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
> > ---
> > Documentation/PCI/MSI-HOWTO.txt | 21 ---------------------
> > Documentation/scsi/ncr53c8xx.txt | 4 +++-
> > Documentation/scsi/tmscsim.txt | 4 ++--
> > 3 files changed, 5 insertions(+), 24 deletions(-)
>
> > diff --git a/Documentation/scsi/ncr53c8xx.txt b/Documentation/scsi/ncr53c8xx.txt
> > index cda5f8f..654b34c 100644
> > --- a/Documentation/scsi/ncr53c8xx.txt
> > +++ b/Documentation/scsi/ncr53c8xx.txt
> > @@ -786,7 +786,9 @@ port address 0x1400.
> > irqm:1 same as initial settings (assumed BIOS settings)
> > irqm:2 always totem pole
> > irqm:0x10 driver will not use IRQF_SHARED flag when requesting irq
> > - irqm:0x20 driver will not use IRQF_DISABLED flag when requesting irq
> > + irqm:0x20 driver will not use IRQF_DISABLED(Does not make sense
> > + anymore since genirq will keep irq disabled and the flag
>
> will not use IRQF_DISABLED (does not make sense
> any more

Updated.

>
> > + is dead from linux-2.6.36) flag when requesting irq

Ah, should be linux-2.6.35 here.

> >
> > (Bits 0x10 and 0x20 can be combined with hardware irq mode option)
> >
> > diff --git a/Documentation/scsi/tmscsim.txt b/Documentation/scsi/tmscsim.txt
> > index 61c0531..45cfd63 100644
> > --- a/Documentation/scsi/tmscsim.txt
> > +++ b/Documentation/scsi/tmscsim.txt
> > @@ -108,8 +108,8 @@ MHz PCI bus works for me, though, but I don't recommend using higher clocks
> > than the 33.33 MHz being in the PCI spec.
> >
> > If you want to share the IRQ with another device and the driver refuses to
> > -do so, you might succeed with changing the DC390_IRQ type in tmscsim.c to
> > -IRQF_SHARED | IRQF_DISABLED.
> > +do so, you should find out what's the mismatch between the shared irqs,
>
> do so, you should IRQs,

Updated.

Thanks Randy.

Yong