public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org
Cc: Raphael Prevost <raphael@buro.asia>,
	Suresh Siddha <suresh.b.siddha@intel.com>,
	Peter Anvin <hpa@zytor.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/5] i387: math_state_restore() isn't called from asm
Date: Wed, 22 Feb 2012 12:56:06 -0800 (PST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1202221255150.20522@i5.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.2.02.1202221252060.20522@i5.linux-foundation.org>


From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mon, 13 Feb 2012 13:47:25 -0800

[ Upstream commit be98c2cdb15ba26148cd2bd58a857d4f7759ed38 ]

It was marked asmlinkage for some really old and stale legacy reasons.
Fix that and the equally stale comment.

Noticed when debugging the irq_fpu_usable() bugs.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: stable@kernel.org	# Helps back-porting
---

Ok, this is trivial, but correct, and avoids the silly clashes with the 
other patches.

 arch/x86/include/asm/i387.h |    2 +-
 arch/x86/kernel/traps.c     |    6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/include/asm/i387.h b/arch/x86/include/asm/i387.h
index c9e09ea05644..cba143210780 100644
--- a/arch/x86/include/asm/i387.h
+++ b/arch/x86/include/asm/i387.h
@@ -29,7 +29,7 @@ extern unsigned int sig_xstate_size;
 extern void fpu_init(void);
 extern void mxcsr_feature_mask_init(void);
 extern int init_fpu(struct task_struct *child);
-extern asmlinkage void math_state_restore(void);
+extern void math_state_restore(void);
 extern void __math_state_restore(void);
 extern int dump_fpu(struct pt_regs *, struct user_i387_struct *);
 
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index a8e3eb83466c..727e6c16f294 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -590,10 +590,10 @@ void __math_state_restore(void)
  * Careful.. There are problems with IBM-designed IRQ13 behaviour.
  * Don't touch unless you *really* know how it works.
  *
- * Must be called with kernel preemption disabled (in this case,
- * local interrupts are disabled at the call-site in entry.S).
+ * Must be called with kernel preemption disabled (eg with local
+ * local interrupts as in the case of do_device_not_available).
  */
-asmlinkage void math_state_restore(void)
+void math_state_restore(void)
 {
 	struct thread_info *thread = current_thread_info();
 	struct task_struct *tsk = thread->task;
-- 
1.7.9.188.g12766.dirty


  reply	other threads:[~2012-02-22 20:56 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-22 20:54 [PATCH 0/5] i387: stable kernel backport Linus Torvalds
2012-02-22 20:56 ` Linus Torvalds [this message]
2012-02-22 20:56   ` [PATCH 2/5] i387: make irq_fpu_usable() tests more robust Linus Torvalds
2012-02-22 20:57     ` [PATCH 3/5] i387: fix x86-64 preemption-unsafe user stack save/restore Linus Torvalds
2012-02-22 20:58       ` [PATCH 4/5] i387: move TS_USEDFPU clearing out of __save_init_fpu and into callers Linus Torvalds
2012-02-22 20:59         ` [PATCH 5/5] i387: move TS_USEDFPU flag from thread_info to task_struct Linus Torvalds
2012-02-22 21:02 ` [PATCH 0/5] i387: stable kernel backport H. Peter Anvin
2012-02-22 21:19 ` Greg Kroah-Hartman
2012-02-22 21:29   ` Linus Torvalds
2012-02-22 21:30     ` Linus Torvalds
2012-02-22 21:32     ` Greg Kroah-Hartman
2012-02-23 20:09       ` Greg Kroah-Hartman
2012-02-23 20:29         ` H. Peter Anvin
2012-02-23 20:48           ` Greg Kroah-Hartman
2012-02-23 20:51             ` H. Peter Anvin
2012-02-23 21:10               ` Greg Kroah-Hartman
2012-02-23 21:52                 ` Willy Tarreau
2012-02-23 22:11                   ` Linus Torvalds
2012-02-23 22:27                     ` Willy Tarreau
2012-02-23 22:38                       ` Linus Torvalds
2012-02-23 22:48                         ` H. Peter Anvin
2012-02-23 22:52                           ` Willy Tarreau
2012-02-23 22:55                             ` H. Peter Anvin
2012-02-23 23:04                               ` Willy Tarreau
2012-02-23 22:49                         ` Willy Tarreau
2012-02-23 22:59                         ` Greg Kroah-Hartman
2012-02-23 23:05                 ` H. Peter Anvin
2012-02-23 23:16                   ` Greg Kroah-Hartman
2012-02-23 23:18                     ` H. Peter Anvin
2012-02-23 23:19                       ` Suresh Siddha
2012-02-23 23:54                       ` Greg Kroah-Hartman
2012-02-23 23:59                         ` H. Peter Anvin
2012-02-24  0:47                         ` H. Peter Anvin
2012-02-22 22:34 ` H. Peter Anvin
2012-02-22 22:45   ` H. Peter Anvin
2012-02-22 23:15   ` Linus Torvalds
2012-02-22 23:31     ` Linus Torvalds
2012-02-23  0:14       ` H. Peter Anvin
2012-02-23  0:25         ` Linus Torvalds
2012-02-23  0:37           ` Greg Kroah-Hartman
2012-02-23  1:47             ` raphael
2012-02-23  2:55               ` Linus Torvalds
2012-02-23  2:41                 ` raphael
2012-02-23  3:37                   ` Linus Torvalds
2012-02-23 18:15                     ` Greg Kroah-Hartman
2012-02-23 19:36                   ` Greg Kroah-Hartman
2012-02-23 19:41                     ` Linus Torvalds
2012-02-23 19:50                       ` Greg Kroah-Hartman
2012-02-23 19:55                         ` Greg Kroah-Hartman
2012-02-23 20:02                           ` Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2012-02-23 13:57 [PATCH 1/5] i387: math_state_restore() isn't called from asm George Spelvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1202221255150.20522@i5.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raphael@buro.asia \
    --cc=stable@vger.kernel.org \
    --cc=suresh.b.siddha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox