public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Akira Takeuchi <takeuchi.akr@jp.panasonic.com>,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	Carsten Emde <C.Emde@osadl.org>,
	Manfred Spraul <manfred@colorfullife.com>
Subject: Re: [REGRESSION][PATCH] mqueue: Ignore the validity of abs_timeout parameter when message can be performed immediately
Date: Thu, 15 Mar 2012 00:02:47 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.02.1203142346190.2466@ionos> (raw)
In-Reply-To: <20120314144601.ccc50a68.akpm@linux-foundation.org>

B1;2601;0cOn Wed, 14 Mar 2012, Andrew Morton wrote:
> On Fri, 02 Mar 2012 16:42:35 +0900
> Akira Takeuchi <takeuchi.akr@jp.panasonic.com> wrote:
> > @@ -996,6 +1015,10 @@ SYSCALL_DEFINE5(mq_timedreceive, mqd_t, mqdes, char __user *, u_msg_ptr,
> >  		if (filp->f_flags & O_NONBLOCK) {
> >  			spin_unlock(&info->lock);
> >  			ret = -EAGAIN;
> > +		} else if (unlikely(timeout_param_error)) {
> > +			spin_unlock(&info->lock);
> > +			ret = timeout_param_error;
> > +			msg_ptr = NULL; /* just for shutting up warning */

Huch? We are not "just" shutting up some warning because the compiler
is yelling at us. No, either we initialize the variable upfront to
NULL or we skip the whole return path by going to fput directly.

Duh, that code is convoluted enough already.

Thanks,

	tglx


      parent reply	other threads:[~2012-03-14 23:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02  7:42 [REGRESSION][PATCH] mqueue: Ignore the validity of abs_timeout parameter when message can be performed immediately Akira Takeuchi
2012-03-14 21:46 ` Andrew Morton
2012-03-14 22:08   ` Thomas Gleixner
2012-03-15  0:28     ` Thomas Gleixner
2012-03-15  3:48       ` Linus Torvalds
2012-03-15 11:02         ` Thomas Gleixner
2012-03-16  5:11           ` Akira Takeuchi
2012-03-23  0:03             ` Akira Takeuchi
2012-03-23  9:01               ` Thomas Gleixner
2012-03-14 23:02   ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1203142346190.2466@ionos \
    --to=tglx@linutronix.de \
    --cc=C.Emde@osadl.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=takeuchi.akr@jp.panasonic.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox