From: Thomas Gleixner <tglx@linutronix.de>
To: John Stultz <john.stultz@linaro.org>
Cc: linux-kernel@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>
Subject: Re: [PATCH 1/2] time: x86: Fix race switching from vsyscall to non-vsyscall clock
Date: Thu, 15 Mar 2012 01:34:18 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.02.1203150131390.2466@ionos> (raw)
In-Reply-To: <1331769536-4602-2-git-send-email-john.stultz@linaro.org>
On Wed, 14 Mar 2012, John Stultz wrote:
> notrace static noinline int do_realtime(struct timespec *ts)
> {
> unsigned long seq, ns;
> + int mode;
Please keep a newline between declarations and code.
> do {
> seq = read_seqbegin(>od->lock);
> + mode = gtod->clock.vclock_mode;
> ts->tv_sec = gtod->wall_time_sec;
> ts->tv_nsec = gtod->wall_time_nsec;
> ns = vgetns();
> } while (unlikely(read_seqretry(>od->lock, seq)));
> +
> timespec_add_ns(ts, ns);
> - return 0;
> + return mode;
> }
>
> notrace static noinline int do_monotonic(struct timespec *ts)
> {
> unsigned long seq, ns, secs;
> + int mode;
etc. etc.
> do {
next prev parent reply other threads:[~2012-03-15 0:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 23:58 [PATCH 0/2] time: Fix races at clocksource switch time John Stultz
2012-03-14 23:58 ` [PATCH 1/2] time: x86: Fix race switching from vsyscall to non-vsyscall clock John Stultz
2012-03-15 0:34 ` Thomas Gleixner [this message]
2012-03-15 0:42 ` John Stultz
2012-03-15 1:43 ` Andy Lutomirski
2012-03-15 1:46 ` Andy Lutomirski
2012-03-15 20:18 ` John Stultz
2012-03-15 21:01 ` Andy Lutomirski
2012-03-14 23:58 ` [PATCH 2/2] time: Fix change_clocksource locking John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1203150131390.2466@ionos \
--to=tglx@linutronix.de \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox