From: Thomas Gleixner <tglx@linutronix.de>
To: Sasikantha babu <sasikanth.v19@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] setitimer : Return -EFAULT if the user pointer "value" is NULL
Date: Wed, 21 Mar 2012 11:09:41 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.02.1203201812260.2542@ionos> (raw)
In-Reply-To: <1332255115-13036-1-git-send-email-sasikanth.v19@gmail.com>
On Tue, 20 Mar 2012, Sasikantha babu wrote:
> Return -EFAULT if user pointer "value" is NULL.
In principle I agree, though this might break exisiting user space as
this behaviour has been there since Linux 1.1.52
So the right thing to do is to add a WARN_ONCE() in the else path and
schedule the removal of this "feature" for v3.6
> diff --git a/kernel/itimer.c b/kernel/itimer.c
> index 22000c3..f356bdf 100644
> --- a/kernel/itimer.c
> +++ b/kernel/itimer.c
> @@ -279,19 +279,18 @@ SYSCALL_DEFINE3(setitimer, int, which, struct itimerval __user *, value,
> struct itimerval __user *, ovalue)
> {
> struct itimerval set_buffer, get_buffer;
> - int error;
> + int error = -EFAULT;
Instead of ripping the whole thing apart, it's way simpler to just do
if (!value)
return -EFAULT;
Thanks,
tglx
next prev parent reply other threads:[~2012-03-21 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 14:51 [PATCH 1/1] setitimer : Return -EFAULT if the user pointer "value" is NULL Sasikantha babu
2012-03-21 10:09 ` Thomas Gleixner [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-21 14:40 Sasikantha babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1203201812260.2542@ionos \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sasikanth.v19@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox