From: Thomas Gleixner <tglx@linutronix.de>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] genirq: Get rid of unneeded force parameter in irq_finalize_oneshot()
Date: Thu, 22 Mar 2012 15:15:40 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.02.1203221514290.2542@ionos> (raw)
In-Reply-To: <20120322110606.GD17233@dhcp-26-207.brq.redhat.com>
On Thu, 22 Mar 2012, Alexander Gordeev wrote:
> On Thu, Mar 22, 2012 at 11:32:26AM +0100, Thomas Gleixner wrote:
> > Wrong.
> >
> > CPU 0 CPU 1
> >
> > do_exit()
> > check(PF_EXITING)
> > set_bit(IRQTF_RUNTHREAD)
> > ...
> > set(PF_EXITING)
> > exit_irq_thread()
>
> Thomas,
>
> Did not you pick this code with 7140ea1 commit?
>
> @@ -845,6 +842,13 @@ void exit_irq_thread(void)
>
> desc = irq_to_desc(action->irq);
>
> + /*
> + * If IRQTF_RUNTHREAD is set, we need to decrement
> + * desc->threads_active and wake possible waiters.
> + */
> + if (test_and_clear_bit(IRQTF_RUNTHREAD, &action->thread_flags))
> + wake_threads_waitq(desc);
> +
Gah crap. Was looking on the wrong branch. That's what you get for
looking at patches before coffee hit brain.
Thanks,
tglx
prev parent reply other threads:[~2012-03-22 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 14:58 [PATCH 1/3] genirq: Get rid of unneeded force parameter in irq_finalize_oneshot() Alexander Gordeev
2012-03-22 10:32 ` Thomas Gleixner
2012-03-22 11:06 ` Alexander Gordeev
2012-03-22 14:15 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1203221514290.2542@ionos \
--to=tglx@linutronix.de \
--cc=agordeev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox