From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751872Ab2DCIYG (ORCPT ); Tue, 3 Apr 2012 04:24:06 -0400 Received: from www.linutronix.de ([62.245.132.108]:53196 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838Ab2DCIYA (ORCPT ); Tue, 3 Apr 2012 04:24:00 -0400 Date: Tue, 3 Apr 2012 10:23:56 +0200 (CEST) From: Thomas Gleixner To: Russell King - ARM Linux cc: Benjamin Herrenschmidt , Grant Likely , Andreas Schwab , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Milton Miller , Rob Herring , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead In-Reply-To: <20120402225223.GN24211@n2100.arm.linux.org.uk> Message-ID: References: <1329383368-12122-1-git-send-email-grant.likely@secretlab.ca> <1329383368-12122-7-git-send-email-grant.likely@secretlab.ca> <20120402202848.1EB833E02A7@localhost> <20120402215524.GM24211@n2100.arm.linux.org.uk> <1333406005.30734.61.camel@pasglop> <20120402225223.GN24211@n2100.arm.linux.org.uk> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Apr 2012, Russell King - ARM Linux wrote: > If we want to fix it a better way, then sure, that'll be good. But what > we shouldn't do is re-introduce one regression to fix a different > regression. > > So, Thomas, what do you think about providing a way that a disabled > interrupt could have its pending status cleared such that when it's > enabled, any queued events are ignored? Maybe an enable_and_clear_irq() ? We can make it a flag, which you can either add to the irq itself or hand it in on request_irq(). Does that require a special chip->callback() function as well ? Thanks, tglx