From: Thomas Gleixner <tglx@linutronix.de>
To: David Rientjes <rientjes@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT pull] timer updates for 3.4-rc
Date: Sat, 7 Apr 2012 01:48:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1204070148420.2542@ionos> (raw)
In-Reply-To: <alpine.DEB.2.00.1204061636260.32765@chino.kir.corp.google.com>
On Fri, 6 Apr 2012, David Rientjes wrote:
> On Sat, 7 Apr 2012, Thomas Gleixner wrote:
>
> > diff --git a/kernel/itimer.c b/kernel/itimer.c
> > index 22000c3..c70369a 100644
> > --- a/kernel/itimer.c
> > +++ b/kernel/itimer.c
> > @@ -284,8 +284,11 @@ SYSCALL_DEFINE3(setitimer, int, which, struct itimerval __user *, value,
> > if (value) {
> > if(copy_from_user(&set_buffer, value, sizeof(set_buffer)))
> > return -EFAULT;
> > - } else
> > + } else {
> > memset((char *) &set_buffer, 0, sizeof(set_buffer));
> > + WARN_ONCE(1, "setitimer: new_value pointer is NULL."
> > + " Misfeature support will be removed\n");
> > + }
> >
> > error = do_setitimer(which, &set_buffer, ovalue ? &get_buffer : NULL);
> > if (error || !ovalue)
>
> When I tried doing this for the deprecated /proc/pid/oom_adj there was a
> complaint that WARN_ONCE() screws up log parsing scripts that think there
> is a kernel issue so I had to change it to printk_once() and include
> get_task_comm(current) and current->pid. See
> http://lkml.indiana.edu/hypermail/linux/kernel/1108.0/00446.html
Bah.
next prev parent reply other threads:[~2012-04-06 23:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 23:32 [GIT pull] timer updates for 3.4-rc Thomas Gleixner
2012-04-06 23:37 ` David Rientjes
2012-04-06 23:48 ` Thomas Gleixner [this message]
2012-04-06 23:58 ` Andrew Morton
2012-04-06 23:59 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1204070148420.2542@ionos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox