public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Michael Witten <mfwitten@gmail.com>
Cc: Arjan van de Ven <arjanvandeven@gmail.com>,
	Arjan van de Ven <arjan@infradead.org>,
	John Stultz <johnstul@us.ibm.com>, Len Brown <lenb@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource: Load the ACPI PM clocksource asynchronously
Date: Wed, 11 Apr 2012 23:13:05 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1204112303270.2542@ionos> (raw)
In-Reply-To: <041683e0088341c2b6d78e97f05948eb-mfwitten@gmail.com>

On Wed, 11 Apr 2012, Michael Witten wrote:
> On Sun, 8 Apr 2012 19:20:22 -0700, Arjan van de Ven wrote:
> 
> >> to which I bisected as the culprit for very strange load balance
> >> behavior on my machine.
> >>
> >> With this patch in place, my CPU is constantly being pegged at 100%
> >> (and my CPU monitor sometimes registers NaN%), regardless of the
> >> active governor and under conditions when my computer would normally
> >> be idling quite placidly.
> >>
> >> Reverting this commit does indeed remove the problem from previously
> >> problematic builds.
> >>
> >>
> > any chance of a dmesg? (or even better, a diff of the dmesg from
> > abefore and fter)
> 
> Doh! I should have thought of that.
> 
> The dmesg output for a kernel built from your patch's commit yields
> this interesting line:
> 
>   PM-Timer running at invalid rate: 113% of normal - aborting.

Duh. The original code does this with interrupts disabled and not from
the context of some random worker thread.

Aside of that, this will blow up if something else touches the CTC
channel 2, which is possible as this code runs async to other init
stuff.

Arjan, did you ever verify that patch extensivly on hardware which
relies on the PM-Timer? I doubt it. :(

There is no other choice than reverting it.

Thanks,

	tglx

  reply	other threads:[~2012-04-11 21:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-31  4:51 [PATCH] clocksource: Load the ACPI PM clocksource asynchronously Arjan van de Ven
2012-02-02  2:40 ` john stultz
2012-04-08  5:58 ` Michael Witten
     [not found]   ` <CADyApD2UZebJd_nSJHAWkjz=PT4_DZfnSr38geqUb1kvJzKi-g@mail.gmail.com>
2012-04-11 20:04     ` Michael Witten
2012-04-11 21:13       ` Thomas Gleixner [this message]
2012-04-11 22:15         ` [tip:timers/urgent] Revert "clocksource: Load the ACPI PM clocksource asynchronously" tip-bot for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1204112303270.2542@ionos \
    --to=tglx@linutronix.de \
    --cc=arjan@infradead.org \
    --cc=arjanvandeven@gmail.com \
    --cc=johnstul@us.ibm.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfwitten@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox