public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@linux.intel.com>
Cc: "Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Jörg Otte" <jrg.otte@googlemail.com>,
	linux-kernel@vger.kernel.org, "Len Brown" <lenb@kernel.org>
Subject: Re: [v3.4-rc1] ACPI regression bisected
Date: Thu, 19 Apr 2012 11:30:31 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1204191125520.2542@ionos> (raw)
In-Reply-To: <4F872C7B.6000106@linux.intel.com>

On Thu, 12 Apr 2012, Andi Kleen wrote:

> 
> > > I feared that. So now is the question whether there is a way to mask
> > > the interrupt at the "device" level.
> 
> Probably not. Len?
> 
> > If not, I could be persuaded to provide a mechanism to force thread
> > all interrupts which are on that line, if there's a good argument to
> > do so.
> 
> Hmm, we could probably just use a work queue for this instead. I guess i drank
> the threaded
> interrupt kool aid too much when I did the patch :-)
> 
> I'll switch over to a workqueue.

That still requires that you can silence the interrupt at the device
level in the first place unless you play silly games with
disable_irq_nosync(), which is even worse than having a
IRQF_FORCE_ONESHOT mechanism in the core.

If you go the workqueue way, then you basically split the interrupt
into a hard irq context and a thread handler. So it's the same to
request a real threaded interrupt with a primary and a thread handler
and return IRQF_WAKE_THREAD conditionally from the primary handler,
when you need the thread context for further processing.

Thoughts?

	tglx


  parent reply	other threads:[~2012-04-19  9:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 15:05 [v3.4-rc1] ACPI regression bisected Jörg Otte
2012-04-02 23:54 ` Andi Kleen
2012-04-03  8:11   ` Thomas Gleixner
2012-04-12  8:35     ` Jörg Otte
2012-04-12  8:57       ` Thomas Gleixner
2012-04-12 11:42         ` Paul Bolle
2012-04-12 17:06           ` Thomas Gleixner
2012-04-12 21:52             ` Paul Bolle
2012-04-12 14:29         ` Matthew Garrett
2012-04-12 17:04           ` Thomas Gleixner
2012-04-12 17:09             ` Thomas Gleixner
2012-04-12 19:26               ` Andi Kleen
2012-04-12 20:42                 ` Thomas Gleixner
2012-04-18  9:25                   ` Paul Bolle
2012-04-18 10:29                     ` Thomas Gleixner
2012-04-18 11:07                       ` Paul Bolle
2012-04-18 17:24                       ` Linus Torvalds
2012-04-18 19:25                         ` Thomas Gleixner
2012-04-19  9:30                 ` Thomas Gleixner [this message]
2012-04-03  9:13   ` Jörg Otte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1204191125520.2542@ionos \
    --to=tglx@linutronix.de \
    --cc=ak@linux.intel.com \
    --cc=jrg.otte@googlemail.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox