Re: [PATCH] kvm: optimize ISR lookups

Avi Kivity
2012-05-23T15:04:35Z

On 05/23/2012 05:48 PM, Ingo Molnar wrote:
>>
>> This is silly. Most of the time the kernel is advanced by
>> incremental patches. Sometimes it is advanced by minor or
>> major refactoring. It is never advanced by personal attacks
>> on contributors.
>
> Thomas wasn't so much doing a personal attack, it was pointing
> out stupidity and then it was mocking the repeated stupidity. He
> very politely explained his point of view (with which I agree),

I guess we disagree on what is polite or not. Mocking, for example,
isn't part of it in my book.

> and then you guys pressed the issue and there's just so many
> hours in the merge window, so you asked to be flamed ...

There is a theory that flaming is a necessary part of kernel
development, but not all maintainers and developers agree with it.
Unfortunately many influential maintainers do.

>
> Avi, if you cannot be brought to properly reject incomplete
> patches going in the wrong direction then others maintainers
> interested in the code will do it.

I happen not to think this is going in the wrong direction, and I
explained why.

>
> If you start to consistently require from KVM contributors
> "incremental updates" in the right direction, not piling crap on
> crap, then such incidents won't happen. This isn't the first
> such incident but there's hope that it might be the last one.

Feel free to point out, politely, when such things happen. Even if you
don't think it will work for some reason, please try it out as an
experiment.

> The rule in arch/x86/ (and many other subsystems) is very
> simple: we don't speed up crappy code. If you want to speed it
> up then make it clean first, *then* is it suited for speedups.
> Crappy code is fragile and bound to introduce bugs, and crappy
> code leads to continued increased maintenance overhead, so
> crappy code is basically under a perpetual code freeze until
> it's uncrapped.

I agree with this as a general principle, but as it happens this
particular bit cannot be uncrapped due to hardware constraints.

--
error compiling committee.c: too many arguments to function