Re: [PATCH] kvm: optimize ISR lookups

Thomas Gleixner
2012-05-23T20:10:31Z

On Wed, 23 May 2012, Avi Kivity wrote:
> On 05/23/2012 05:48 PM, Ingo Molnar wrote:
> >>
> >> This is silly. Most of the time the kernel is advanced by
> >> incremental patches. Sometimes it is advanced by minor or
> >> major refactoring. It is never advanced by personal attacks
> >> on contributors.
> >
> > Thomas wasn't so much doing a personal attack, it was pointing
> > out stupidity and then it was mocking the repeated stupidity. He
> > very politely explained his point of view (with which I agree),
>
> I guess we disagree on what is polite or not. Mocking, for example,
> isn't part of it in my book.

I really avoid flaming as far as it goes, but I consider that ignoring
a thorough patch review and replying only on the very obvious problem
is a massive form of impoliteness. Replying on a still polite reminder
with a sloppy "I just took what's there and implemeted the
optimization which I was tasked with" is even more of an offense. It
clearly shows that there is no interest in making the whole thing
better and just aims for quick and dirty "here are my benchmark
results" success.

This is what actually triggered me to switch into grumpy mode.

I'm really tired of that attitude. It's the root cause for the steady
increasing mess in the kernel.

It forces people who actually care to waste an endless amount of time
to clean up what has been just slapped into the code base quick and
dirty. And you expect those people to stay calm and polite if they get
ignored and ridiculed with sloppy replies?

You may be a saint, but I'm definitely too old to cope with that.

Thanks,

tglx