Re: [PATCH] kvm: optimize ISR lookups

Thomas Gleixner
2012-05-21T22:14:23Z

On Tue, 22 May 2012, Michael S. Tsirkin wrote:

> On Mon, May 21, 2012 at 11:04:25PM +0200, Thomas Gleixner wrote:
> > > @@ -242,6 +262,25 @@ static inline void apic_clear_irr(int vec, struct kvm_lapic *apic)
> > > apic->irr_pending = true;
> > > }
> > >
> > > +static inline void apic_set_isr(int vec, struct kvm_lapic *apic)
> > > +{
> > > + if (!__apic_test_and_set_vector(vec, apic->regs + APIC_ISR))
> > > + ++apic->isr_count;
> > > + ASSERT(apic->isr_count > MAX_APIC_VECTOR);
> >
> > I'm really curious what you observed when defining DEBUG in that file.
> >
> > Clearly you never did.
>
> Sorry :(
> Yes clearly silly, thanks for pointing this out.

That's all you have a reply for? That's the least of the problems ....