From: Thomas Gleixner <tglx@linutronix.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux PM list <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
John Stultz <johnstul@us.ibm.com>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Prarit Bhargava <prarit@redhat.com>,
stable@vger.kernel.org, Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [Regression][Revert request] Excessive delay or hang during resume from system suspend due to a hrtimer commit
Date: Mon, 16 Jul 2012 13:15:47 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1207161315050.32033@ionos> (raw)
In-Reply-To: <201207161316.28875.rjw@sisk.pl>
On Mon, 16 Jul 2012, Rafael J. Wysocki wrote:
> On Monday, July 16, 2012, Thomas Gleixner wrote:
> > On Sun, 15 Jul 2012, Rafael J. Wysocki wrote:
> > > To everyone involved: the fact that this change, which was likely to introduce
> > > regressions from the look of it alone, has been pushed to Linus (an to -stable
> > > at the same time!) so late in the cycle, is seriuosly disappointing.
> >
> > Well, we spent an massive amount of time in testing, reviewing and
> > discussion and it definitely did not break suspend/resume here.
>
> I'm not saying that you didn't consider it thoroughly, but unfortunately you
> did overlook this particular issue, didn't you?
>
> > This was not pushed without a lot of thoughts and in fact what you are
> > seing is another long standing bug in the timekeeping resume code,
> > which was just papered over by the incorrect handling of the clock was
> > set cases in the other parts of the system.
> >
> > Does the following patch fix the problem for you ?
>
> Yes, it does, thanks!
>
> > @John: Should that clear ntp as well or is it enough to set ntp_error
> > to 0 ?
> >
> > /me really goes on vacation now.
>
> So who's going to take care of the patch? :-)
I'm still packing gear. So i'll push it into timers/urgent.
next prev parent reply other threads:[~2012-07-16 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 20:40 [Regression][Revert request] Excessive delay or hang during resume from system suspend due to a hrtimer commit Rafael J. Wysocki
2012-07-16 9:47 ` Thomas Gleixner
2012-07-16 11:16 ` Rafael J. Wysocki
2012-07-16 11:15 ` Thomas Gleixner [this message]
2012-07-16 11:26 ` Thomas Gleixner
2012-07-16 15:47 ` John Stultz
2012-07-16 12:48 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1207161315050.32033@ionos \
--to=tglx@linutronix.de \
--cc=a.p.zijlstra@chello.nl \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=prarit@redhat.com \
--cc=rjw@sisk.pl \
--cc=schwab@linux-m68k.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox