From: Thomas Gleixner <tglx@linutronix.de>
To: Milan Broz <mbroz@redhat.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Tvrtko Ursulin" <tvrtko@ursulin.net>,
linux-rt-users@vger.kernel.org, dm-crypt@saout.de,
linux-kernel@vger.kernel.org, okozina@redhat.com
Subject: Re: [PATCH] Fix crypto api init for 3.6.4-rt10
Date: Tue, 30 Oct 2012 18:57:37 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.02.1210301856390.2756@ionos> (raw)
In-Reply-To: <508FF1D6.3030900@redhat.com>
On Tue, 30 Oct 2012, Milan Broz wrote:
> Fix crypto api for 3.6.4-rt10 (broken only in realtime patchset)
>
> In peterz-srcu-crypto-chain.patch the blocking notifier is changed
> to srcu notifier and added initialization to module init fucntion.
>
> Later, in crypto-make-core-static-and-init-scru-early.patch, is that
> initialization added also to core_initcall().
>
> This patch removes crypto_chain init from algapi initialization,
> because this function is called later and already initialized
> cryptomgr notifier is lost.
Grrr. So I forgot top zap the one Peter added. Stupid me.
> This cause a failure in initialization of larval algorithms,
> like e.g. cbc(aes).
Thanks for spotting!
> Signed-off-by: Milan Broz <mbroz@redhat.com>
>
> --- crypto/algapi.c.old 2012-10-30 16:11:23.000000000 +0100
> +++ crypto/algapi.c 2012-10-30 16:12:14.988847944 +0100
> @@ -956,7 +956,6 @@ EXPORT_SYMBOL_GPL(crypto_xor);
>
> static int __init crypto_algapi_init(void)
> {
> - srcu_init_notifier_head(&crypto_chain);
> crypto_init_proc();
> return 0;
> }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-10-30 17:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 20:44 cryptsetup not working under 3.6 - regression from 3.4? Tvrtko Ursulin
2012-10-21 9:53 ` [dm-crypt] " Milan Broz
2012-10-21 12:03 ` Tvrtko Ursulin
[not found] ` <5083E87B.2080908@gmail.com>
2012-10-21 12:36 ` Tvrtko Ursulin
2012-10-21 19:29 ` Milan Broz
2012-10-21 20:03 ` Tvrtko Ursulin
2012-10-29 19:31 ` Tvrtko Ursulin
2012-10-29 19:47 ` [dm-crypt] " Milan Broz
2012-10-29 20:14 ` Tvrtko Ursulin
2012-10-29 20:45 ` [dm-crypt] cryptsetup not working under 3.6 - RT patch set seem to break it Tvrtko Ursulin
2012-10-29 23:51 ` Thomas Gleixner
2012-10-30 9:40 ` Uwe Kleine-König
2012-10-30 9:55 ` Milan Broz
2012-10-30 15:27 ` [PATCH] Fix crypto api init for 3.6.4-rt10 Milan Broz
2012-10-30 17:57 ` Thomas Gleixner [this message]
2012-10-30 20:35 ` Uwe Kleine-König
2012-10-30 18:24 ` Tvrtko Ursulin
2012-10-29 20:48 ` [dm-crypt] cryptsetup not working under 3.6 - regression from 3.4? Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1210301856390.2756@ionos \
--to=tglx@linutronix.de \
--cc=dm-crypt@saout.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=okozina@redhat.com \
--cc=tvrtko@ursulin.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).