From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758794Ab3BVSwT (ORCPT ); Fri, 22 Feb 2013 13:52:19 -0500 Received: from www.linutronix.de ([62.245.132.108]:59667 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754071Ab3BVSwS (ORCPT ); Fri, 22 Feb 2013 13:52:18 -0500 Date: Fri, 22 Feb 2013 19:52:14 +0100 (CET) From: Thomas Gleixner To: Lorenzo Pieralisi cc: Santosh Shilimkar , Jason Liu , LKML , "linux-arm-kernel@lists.infradead.org" Subject: Re: too many timer retries happen when do local timer swtich with broadcast timer In-Reply-To: <20130222152639.GH12140@e102568-lin.cambridge.arm.com> Message-ID: References: <51263975.20906@ti.com> <5127436E.4040100@ti.com> <20130222103149.GC12140@e102568-lin.cambridge.arm.com> <51275058.7010809@ti.com> <20130222144829.GG12140@e102568-lin.cambridge.arm.com> <20130222152639.GH12140@e102568-lin.cambridge.arm.com> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Feb 2013, Lorenzo Pieralisi wrote: > On Fri, Feb 22, 2013 at 03:03:02PM +0000, Thomas Gleixner wrote: > > On Fri, 22 Feb 2013, Lorenzo Pieralisi wrote: > > > On Fri, Feb 22, 2013 at 12:07:30PM +0000, Thomas Gleixner wrote: > > > > Now we could make use of that and avoid going deep idle just to come > > > > back right away via the IPI. Unfortunately the notification thingy has > > > > no return value, but we can fix that. > > > > > > > > To confirm that theory, could you please try the hack below and add > > > > some instrumentation (trace_printk)? > > > > > > Applied, and it looks like that's exactly why the warning triggers, at least > > > on the platform I am testing on which is a dual-cluster ARM testchip. > > > > > > There is a still time window though where the CPU (the IPI target) can get > > > back to idle (tick_broadcast_pending still not set) before the CPU target of > > > the broadcast has a chance to run tick_handle_oneshot_broadcast (and set > > > tick_broadcast_pending), or am I missing something ? > > > > Well, the tick_broadcast_pending bit is uninteresting if the > > force_broadcast bit is set. Because if that bit is set we know for > > sure, that we got woken with the cpu which gets the broadcast timer > > and raced back to idle before the broadcast handler managed to > > send the IPI. > > Gah, my bad sorry, I mixed things up. I thought > > tick_check_broadcast_pending() > > was checking against the tick_broadcast_pending mask not > > tick_force_broadcast_mask Yep, that's a misnomer. I just wanted to make sure that my theory is correct. I need to think about the real solution some more. We have two alternatives: 1) Make the clockevents_notify function have a return value. 2) Add something like the hack I gave you with a proper name. The latter has the beauty, that we just need to modify the platform independent idle code instead of going down to every callsite of the clockevents_notify thing. Thanks, tglx