From: Thomas Gleixner <tglx@linutronix.de>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: Feng Tang <feng.tang@intel.com>,
John Stultz <john.stultz@linaro.org>, Ingo Molnar <mingo@elte.hu>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
x86@kernel.org, Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-kernel@vger.kernel.org, gong.chen@linux.intel.com
Subject: Re: [PATCH v3 4/5] clocksource: Enable clocksource_cyc2ns() to cover big cycles
Date: Wed, 6 Mar 2013 22:29:21 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.02.1303062225460.22263@ionos> (raw)
In-Reply-To: <5137B30D.8060509@linux.intel.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1109 bytes --]
On Wed, 6 Mar 2013, H. Peter Anvin wrote:
> On 03/06/2013 01:15 PM, Thomas Gleixner wrote:
> > On Wed, 6 Mar 2013, H. Peter Anvin wrote:
> >
> >> On 03/06/2013 06:09 AM, Thomas Gleixner wrote:
> >>>
> >>> This breaks everything which does not have a 64/32bit divide
> >>> instruction. And you can't replace it with do_div() as that would
> >>> impose massive overhead on those architectures in the fast path.
> >>>
> >>
> >> Could we do the same kind of scaling-by-multiplication that we do in
> >> kernel/time.c for this?
> >
> > Not sure what you are referring to. kernel/time.c contains a lot of stuff :)
> >
>
> This stuff, specifically the third clause (which incidentally could be
> extended to the fourth clause without much trouble... I have
> experimented with it already.)
>
> It uses a N*N->2N multiply and a shift to do overflowless scaling; it is
> ±1 LSB in the upper half of the value range with can be remedied with an
> additional 2N add.
That's compile time. We need this at runtime and we do not want to
reduce the accuracy. That's precision timekeeping not jiffies :)
Thanks,
tglx
next prev parent reply other threads:[~2013-03-06 21:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 7:17 [PATCH v3 0/5] Add support for S3 non-stop TSC support Feng Tang
2013-03-06 7:17 ` [PATCH v3 1/5] x86: Add cpu capability flag X86_FEATURE_NONSTOP_TSC_S3 Feng Tang
2013-03-06 7:17 ` [PATCH v3 2/5] clocksource: Add new feature flag CLOCK_SOURCE_SUSPEND_NONSTOP Feng Tang
2013-03-06 7:17 ` [PATCH v3 3/5] x86: tsc: Add support for new S3_NONSTOP feature Feng Tang
2013-03-06 7:17 ` [PATCH v3 4/5] clocksource: Enable clocksource_cyc2ns() to cover big cycles Feng Tang
2013-03-06 14:09 ` Thomas Gleixner
2013-03-06 14:37 ` Feng Tang
2013-03-06 16:10 ` Thomas Gleixner
2013-03-06 16:26 ` Feng Tang
2013-03-06 21:05 ` H. Peter Anvin
2013-03-06 21:15 ` Thomas Gleixner
2013-03-06 21:20 ` H. Peter Anvin
2013-03-06 21:29 ` Thomas Gleixner [this message]
2013-03-06 7:17 ` [PATCH v3 5/5] timekeeping: utilize the suspend-nonstop clocksource to count suspended time Feng Tang
2013-03-06 14:15 ` Thomas Gleixner
2013-03-06 14:29 ` Feng Tang
2013-03-06 21:33 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1303062225460.22263@ionos \
--to=tglx@linutronix.de \
--cc=feng.tang@intel.com \
--cc=gong.chen@linux.intel.com \
--cc=hpa@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=john.stultz@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rafael.j.wysocki@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox