From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Stephane Eranian <eranian@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@redhat.com>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf,x86: fix kernel crash with PEBS/BTS after suspend/resume
Date: Fri, 15 Mar 2013 21:49:25 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.02.1303152149090.22263@ionos> (raw)
In-Reply-To: <CA+55aFxqibqOvWcv691ZciO7rXpRFUL=zZVVGRSbD4N1Sz+fFQ@mail.gmail.com>
On Fri, 15 Mar 2013, Linus Torvalds wrote:
> On Fri, Mar 15, 2013 at 6:26 AM, Stephane Eranian <eranian@google.com> wrote:
> >
> > This patch fixes a kernel crash when using precise sampling (PEBS)
> > after a suspend/resume.
>
> Yup, works. Applied.
>
> Can we please get rid of the crazy CPU notifier crap from the perf
> code, and do this like we do most other wrmsr's etc? Doing
>
> git grep "case CPU_" arch/x86/kernel/cpu
>
> shows that the perf layer seems to be full of this kind of BS. This is
> all CPU state, it should be initialized by the regular CPU
> initialization code, not hooked up with some random callbacks.
It's on my list ....
next prev parent reply other threads:[~2013-03-15 20:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 13:26 [PATCH] perf,x86: fix kernel crash with PEBS/BTS after suspend/resume Stephane Eranian
2013-03-15 17:01 ` Linus Torvalds
2013-03-15 20:49 ` Thomas Gleixner [this message]
2013-03-15 20:31 ` Greg KH
2013-03-15 20:49 ` Stephane Eranian
2013-03-15 20:56 ` Greg KH
2013-03-15 20:53 ` Shuah Khan
2013-03-15 20:56 ` Stephane Eranian
2013-03-16 0:45 ` Shuah Khan
2013-03-16 16:11 ` Parag Warudkar
2013-03-16 17:56 ` Linus Torvalds
2013-03-16 22:06 ` Parag Warudkar
2013-03-17 22:49 ` [patch for-] perf,x86: fix link failure for non-Intel configs David Rientjes
2013-03-18 0:12 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1303152149090.22263@ionos \
--to=tglx@linutronix.de \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox