Re: [patch 29/34] sh: Use generic idle loop

Srivatsa S. Bhat
2013-03-28T15:42:55Z

On 03/22/2013 03:23 AM, Thomas Gleixner wrote:
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Paul Mundt <lethal@linux-sh.org>
> ---
[...]

> -/*
> - * The idle thread. There's no useful work to be done, so just try to conserve
> - * power and have a low exit latency (ie sit in a loop waiting for somebody to
> - * say that they'd like to reschedule)
> - */
> -void cpu_idle(void)
> +void arch_cpu_idle(void)
> {
> - unsigned int cpu = smp_processor_id();
> -
> - set_thread_flag(TIF_POLLING_NRFLAG);
> -
> - /* endless idle loop with no priority at all */
> - while (1) {
> - tick_nohz_idle_enter();
> - rcu_idle_enter();
> -
> - while (!need_resched()) {
> - check_pgt_cache();
> - rmb();
> -
> - if (cpu_is_offline(cpu))
> - play_dead();
> -
> - local_irq_disable();
> - /* Don't trace irqs off for idle */
> - stop_critical_timings();
> - if (cpuidle_idle_call())
> - sh_idle();
> - /*
> - * Sanity check to ensure that sh_idle() returns
> - * with IRQs enabled
> - */
> - WARN_ON(irqs_disabled());
> - start_critical_timings();
> - }
> -
> - rcu_idle_exit();
> - tick_nohz_idle_exit();
> - schedule_preempt_disabled();
> - }
> + if (cpuidle_idle_call())
> + sh_idle();
> }
>

Missing call to play_dead(). Perhaps you can fold the following diff:

diff --git a/arch/sh/kernel/idle.c b/arch/sh/kernel/idle.c
index 8b9d5d7..2ea4483 100644
--- a/arch/sh/kernel/idle.c
+++ b/arch/sh/kernel/idle.c
@@ -33,6 +33,11 @@ void default_idle(void)
clear_bl_bit();
}

+void arch_cpu_idle_dead(void)
+{
+ play_dead();
+}
+
void arch_cpu_idle(void)
{
if (cpuidle_idle_call())

Regards,
Srivatsa S. Bhat