Re: [patch 08/34] arm: Use generic idle loop

Thomas Gleixner
2013-03-25T11:31:24Z

On Fri, 22 Mar 2013, Kevin Hilman wrote:

> Hi Thomas,
>
> Thomas Gleixner <tglx@linutronix.de> writes:
>
> > Use the generic idle loop and replace enable/disable_hlt with the
> > respective core functions.
> >
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Russell King <linux@arm.linux.org.uk>
>
> I gave patches 1-5 + this a quick spin on ARM (specifially some OMAP3 and
> OMAP4 platforms, with and without CPUidle enabled.)
>
> The OMAP stuff needed a couple minor compile fixes (below), but
> otherwise it passes the quick "seems to work" test.

Yeah, that's needed for the other arch/arm conversions as well.

Thanks,

tglx

> So at least for ARM/OMAP:
>
> Tested-by: Kevin Hilman <khilman@linaro.org>
>
> Kevin
>
>
> diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c
> index 23c653a..db37f49 100644
> --- a/arch/arm/mach-omap1/pm.c
> +++ b/arch/arm/mach-omap1/pm.c
> @@ -43,6 +43,7 @@
> #include <linux/module.h>
> #include <linux/io.h>
> #include <linux/atomic.h>
> +#include <linux/cpu.h>
>
> #include <asm/fncpy.h>
> #include <asm/system_misc.h>
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index 3a6c6b8..2f17f95 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -138,6 +138,7 @@
> #include <linux/spinlock.h>
> #include <linux/slab.h>
> #include <linux/bootmem.h>
> +#include <linux/cpu.h>
>
> #include <asm/system_misc.h>
>