Re: [patch 02/34] arch: Consolidate tsk_is_polling()

Tony Breeds
2013-03-22T05:20:19Z

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

On Thu, Mar 21, 2013 at 09:52:57PM -0000, Thomas Gleixner wrote:

> +/*
> + * Idle thread specific functions to determine the need_resched
> + * polling state. We have two versions, one based on TS_POLLING in
> + * thread_info.status and one based on TIF_POLLING_NRFLAG in
> + * thread_info.flags
> + */
> +#ifdef TS_POLLING
> +static inline int tsk_is_polling(struct task_struct *p)
> +{
> + return task_thread_info(p)->status & TS_POLLING;
> +}
> +#elif defined(TIF_POLLING_NRFLAG)
> +static inline int tsk_is_polling(struct task_struct *p)
> +{
> + test_tsk_thread_flag(p, TIF_POLLING_NRFLAG);
> +}

On powerpc (at least) this is used before it's declared. Also I think
you're missing a 'return' in that function.

*cough* https://www.kernel.org/pub/tools/crosstool/ *cough*

Yours Tony

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]