Re: [PATCH] futex: bugfix for futex-key conflict when futex use hugepage

Thomas Gleixner
2013-04-25T20:52:41Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1344 bytes --]

On Wed, 24 Apr 2013, Zhang Yi wrote:

> Hi all,
>
> I reworked the patch base on your advices。
> For the line-wrapped bug before, I use this mailbox to send the mail .

Unfortunately this did not work out very well.

1. Your patch now lacks a proper changelog which explains the change

2. Your patch lacks any newline characters as you can see below

>
> Signed-off-by: Zhang Yi <zhang.yi20@zte.com.cn>Tested-by: Ma Chenggong <ma.chenggong@zte.com.cn>Reviewed-by: Liu Dong <liu.dong3@zte.com.cn>Reviewed-by: Cui Yunfeng <cui.yunfeng@zte.com.cn>Reviewed-by: Lu Zhongjun <lu.zhongjun@zte.com.cn>Reviewed-by: Jiang Biao <jiang.biao2@zte.com.cn>
>
> diff -uprN orig/linux3.9-rc7/include/linux/futex.h new/linux3.9-rc7/include/linux/futex.h--- orig/linux3.9-rc7/include/linux/futex.h 2013-04-15 00:45:16.000000000 +0000+++ new/linux3.9-rc7/include/linux/futex.h 2013-04-19 16:33:58.725880000 +0000@@ -19,7 +19,7 @@ handle_futex_death(u32 __user *uaddr, st  * The key type depends on whether it's a shared or private mapping.  * Don't rearrange members without looking at hash_futex().  *- * offset is aligned to a multiple of sizeof(u32) (==

Please read Documentation/SubmittingPatches and
Documentation/email-clients.txt. And as I said before: Send the mail
to yourself or a coworker and verify that it can be applied.

Thanks,

tglx