From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: DEC: remove unbuildable promcon.c
Date: Sat, 8 Jun 2013 19:54:30 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.03.1306081950280.21418@linux-mips.org> (raw)
In-Reply-To: <1369909215.23034.39.camel@x61.thuisdomein>
On Thu, 30 May 2013, Paul Bolle wrote:
> promcon.o is built if CONFIG_PROM_CONSOLE is set. But there's no Kconfig
> symbol PROM_CONSOLE, so promcon.c is unbuildable. Remove it.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Untested.
>
> 1) There used to be a Kconfig symbol PROM_CONSOLE. But it was SPARC
> specific and it was removed in v2.6.32, see commit 09d3f3f0e0 ("sparc:
> Kill PROM console driver.").
>
> 2) Actually, it seems that it has never been possible to set
> PROM_CONSOLE for MIPS ever since this file was added in v2.3.9. I guess
> no-one noticed because (what seems to be) comparable functionality is
> provided in arch/mips/dec/prom/console.c.
Yeah, I think over the years the file mostly served documentation
purposes. Given that we've had (as you also noticed) a working early-boot
console available:
Acked-by: Maciej W. Rozycki <macro@linux-mips.org>
Thanks for this clean-up.
Maciej
prev parent reply other threads:[~2013-06-08 18:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 10:20 [PATCH] MIPS: DEC: remove unbuildable promcon.c Paul Bolle
2013-06-08 18:54 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.03.1306081950280.21418@linux-mips.org \
--to=macro@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pebolle@tiscali.nl \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox