Re: [PATCH V2 2/2] drivers/s390/cio/qdio_main.c: replace shift loop by ilog2

[Sebastian Ott <sebott@linux.vnet.ibm.com>]

On Tue, 3 Jun 2014, Fabian Frederick wrote:
> account_sbals is called by get_inbound_buffer_frontier and
> get_outbound_buffer_frontier with 'count' value > 0 so we can safely convert
> shift loop to ilog2.
> 
> Cc: Sebastian Ott <sebott@linux.vnet.ibm.com>
> Cc: Joe Perches <joe@perches.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  drivers/s390/cio/qdio_main.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/s390/cio/qdio_main.c b/drivers/s390/cio/qdio_main.c
> index 9fda160..2eee7f1 100644
> --- a/drivers/s390/cio/qdio_main.c
> +++ b/drivers/s390/cio/qdio_main.c
> @@ -413,15 +413,14 @@ static inline void qdio_stop_polling(struct qdio_q *q)
> 
>  static inline void account_sbals(struct qdio_q *q, unsigned int count)
>  {
> -	int pos = 0;
> +	int pos;
> 
>  	q->q_stats.nr_sbal_total += count;
>  	if (count == QDIO_MAX_BUFFERS_MASK) {
>  		q->q_stats.nr_sbals[7]++;
>  		return;
>  	}
> -	while (count >>= 1)
> -		pos++;
> +	pos = ilog2(count);
>  	q->q_stats.nr_sbals[pos]++;
>  }
> 
> -- 
> 1.8.4.5
> 
> 

Thanks, applied.
Sebastian