From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934296AbcA0Wox (ORCPT ); Wed, 27 Jan 2016 17:44:53 -0500 Received: from mail-pf0-f182.google.com ([209.85.192.182]:35129 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932216AbcA0Wot (ORCPT ); Wed, 27 Jan 2016 17:44:49 -0500 From: Stafford Horne X-Google-Original-From: Stafford Horne Date: Thu, 28 Jan 2016 07:44:35 +0900 (JST) To: Jiri Kosina cc: Stafford Horne , benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] HID: quirks: Add no_init_reports for AKAI midi controller In-Reply-To: Message-ID: References: <1453903777-11790-1-git-send-email-shorne@gmail.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Jan 2016, Jiri Kosina wrote: > On Wed, 27 Jan 2016, Stafford Horne wrote: > >> The midi controller times-out while initializing reports, this >> causes boot to take an extra 10 seconds. The device descriptor >> advertises that it has an internal HID device but seems to not >> actually do anything useful. >> >> Signed-off-by: Stafford Horne >> --- >> drivers/hid/hid-ids.h | 3 +++ >> drivers/hid/usbhid/hid-quirks.c | 1 + >> 2 files changed, 4 insertions(+) >> >> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h >> index b6ff6e7..3dfb166 100644 >> --- a/drivers/hid/hid-ids.h >> +++ b/drivers/hid/hid-ids.h >> @@ -61,6 +61,9 @@ >> #define USB_VENDOR_ID_AIREN 0x1a2c >> #define USB_DEVICE_ID_AIREN_SLIMPLUS 0x0002 >> >> +#define USB_VENDOR_ID_AKAI 0x2011 >> +#define USB_DEVICE_ID_AKAI_MPKMINI2 0x0715 >> + >> #define USB_VENDOR_ID_ALCOR 0x058f >> #define USB_DEVICE_ID_ALCOR_USBRS232 0x9720 >> >> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c >> index 7dd0953..055e740 100644 >> --- a/drivers/hid/usbhid/hid-quirks.c >> +++ b/drivers/hid/usbhid/hid-quirks.c >> @@ -55,6 +55,7 @@ static const struct hid_blacklist { >> { USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT }, >> >> { USB_VENDOR_ID_AIREN, USB_DEVICE_ID_AIREN_SLIMPLUS, HID_QUIRK_NOGET }, >> + { USB_VENDOR_ID_AKAI, USB_DEVICE_ID_AKAI_MPKMINI2, HID_QUIRK_NO_INIT_REPORTS }, > > If the (proclaimed) HID device is completely silent, wouldn't > HID_QUIRK_IGNORE be more appropriate? You are right, I did NO_INIT_REPORTS because thats where the timeout was. But after further investigation I found that device is silent. I will change, test and resubmit a new patch version. -Stafford