From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752177AbdKMXmd (ORCPT ); Mon, 13 Nov 2017 18:42:33 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:35632 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbdKMXm3 (ORCPT ); Mon, 13 Nov 2017 18:42:29 -0500 Date: Tue, 14 Nov 2017 10:41:50 +1100 (AEDT) From: James Morris X-X-Sender: james.l.morris@localhost To: Jarkko Sakkinen cc: intel-sgx-kernel-dev@lists.01.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 06/11] intel_sgx: driver for Intel Software Guard Extensions In-Reply-To: <20171113194528.28557-7-jarkko.sakkinen@linux.intel.com> Message-ID: References: <20171113194528.28557-1-jarkko.sakkinen@linux.intel.com> <20171113194528.28557-7-jarkko.sakkinen@linux.intel.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Nov 2017, Jarkko Sakkinen wrote: > + > + secs_epc = sgx_alloc_page(0); Use SGX_ALLOC_ATOMIC instead of 0 ? > + if (IS_ERR(secs_epc)) { > + ret = PTR_ERR(secs_epc); > + goto out; > + } > +out: > + if (encl) > + kref_put(&encl->refcount, sgx_encl_release); > + return ret; > +} Don't you need an sgx_free_page() somewhere here? -- James Morris