From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbdLECI7 (ORCPT ); Mon, 4 Dec 2017 21:08:59 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:53986 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751744AbdLECIz (ORCPT ); Mon, 4 Dec 2017 21:08:55 -0500 X-Greylist: delayed 6631 seconds by postgrey-1.27 at vger.kernel.org; Mon, 04 Dec 2017 21:08:55 EST Date: Tue, 5 Dec 2017 11:18:10 +1100 (AEDT) From: James Morris X-X-Sender: james.l.morris@localhost To: Colin King cc: David Howells , "Serge E . Hallyn" , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] security: keys: remove redundant assignment to key_ref In-Reply-To: <20171204181424.15808-1-colin.king@canonical.com> Message-ID: References: <20171204181424.15808-1-colin.king@canonical.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8735 signatures=668637 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712050002 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 4 Dec 2017, Colin King wrote: > From: Colin Ian King > > Variable key_ref is being assigned a value that is never read; > key_ref is being re-assigned a few statements later. Hence this > assignment is redundant and can be removed. > > Signed-off-by: Colin Ian King I think a general cleanup in that function to make all of these follow the pattern: if (something) { key_ref = ERR_PTR(-error); goto error; } rather than unconditionally setting the error first, would be better, but this is a clear enough fix on its own. Reviewed-by: James Morris -- James Morris