public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Ott <sebott@linux.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Kees Cook <keescook@chromium.org>,
	Sebastian Ott <sebott@linux.vnet.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Uecker <Martin.Uecker@med.uni-goettingen.de>,
	Ingo Molnar <mingo@kernel.org>,
	Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Subject: Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390
Date: Mon, 9 Apr 2018 19:27:43 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.21.1804091926080.1698@schleppi> (raw)
In-Reply-To: <CA+55aFy1jJPX2fu7ce2Z7hxn49RaSghtnziwsyUU1Em5WEH2yw@mail.gmail.com>

On Mon, 9 Apr 2018, Linus Torvalds wrote:
> On Mon, Apr 9, 2018 at 10:03 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Our old "min()" had the internal variables called "min1" and "min2",
> > which is crazy too.
> 
> Actually, no, it used the really cumbersome "__UNIQUE_ID" and then
> passed that odd as the name 'min1/2',
> 
> Ugh, I find that really nasty to read, but it was obviously done
> because we hit this before.
> 
> And our __UNIQUE_ID() macro is garbage anyway, since it falls back on
> the line number, which doesn't really work for macros anyway. But we
> have proper macros for both clang and gcc, so maybe we should ignore
> the broken fallback.
> 
> A patch like the attached, perhaps?

I applied this on top of 38c23685b273cfb4ccf31a199feccce3bdcb5d83
and everything works as expected.

Thanks!

  reply	other threads:[~2018-04-09 17:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06  9:47 [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390 Sebastian Ott
2018-04-06 16:47 ` Kees Cook
2018-04-06 18:02   ` Kees Cook
2018-04-06 18:10     ` Sebastian Ott
2018-04-09 16:18   ` Sebastian Ott
2018-04-09 17:00     ` Sebastian Ott
2018-04-09 17:03     ` Linus Torvalds
2018-04-09 17:11       ` Sebastian Ott
2018-04-09 17:15         ` Linus Torvalds
2018-04-09 17:14       ` Linus Torvalds
2018-04-09 17:27         ` Sebastian Ott [this message]
2018-04-09 17:32         ` Linus Torvalds
2018-04-09 18:00         ` Kees Cook
2018-04-09 18:17           ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.21.1804091926080.1698@schleppi \
    --to=sebott@linux.ibm.com \
    --cc=Martin.Uecker@med.uni-goettingen.de \
    --cc=heiko.carstens@de.ibm.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mingo@kernel.org \
    --cc=sebott@linux.vnet.ibm.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox