* [PATCH] kernel: prevent unnecessary rebuilding due to config_data.gz
@ 2011-07-05 23:42 Peter Foley
2011-07-06 15:33 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Peter Foley @ 2011-07-05 23:42 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: rdunlap
When IKCONFIG is built-in make oldconfig will cause the kernel to be
relinked even if .config didn't change. This happens because of a
config_data.gz dependency on .config. This patch changes the if_changed to
a filechk so that config_data.h is only rebuilt when the contents
have actually changed.
Signed-off-by: Peter Foley <pefoley2@verizon.net>
---
kernel/Makefile | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/Makefile b/kernel/Makefile
index 2d64cfc..d06467f 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -125,11 +125,10 @@ targets += config_data.gz
$(obj)/config_data.gz: $(KCONFIG_CONFIG) FORCE
$(call if_changed,gzip)
-quiet_cmd_ikconfiggz = IKCFG $@
- cmd_ikconfiggz = (echo "static const char kernel_config_data[] __used = MAGIC_START"; cat $< | scripts/bin2c; echo "MAGIC_END;") > $@
+ filechk_ikconfiggz = (echo "static const char kernel_config_data[] __used = MAGIC_START"; cat $< | scripts/bin2c; echo "MAGIC_END;")
targets += config_data.h
$(obj)/config_data.h: $(obj)/config_data.gz FORCE
- $(call if_changed,ikconfiggz)
+ $(call filechk,ikconfiggz)
$(obj)/time.o: $(obj)/timeconst.h
--
1.7.5.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kernel: prevent unnecessary rebuilding due to config_data.gz
2011-07-05 23:42 [PATCH] kernel: prevent unnecessary rebuilding due to config_data.gz Peter Foley
@ 2011-07-06 15:33 ` Randy Dunlap
2011-07-15 2:52 ` Peter Foley
2011-07-19 23:33 ` Michal Marek
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2011-07-06 15:33 UTC (permalink / raw)
To: Peter Foley, Michal Marek; +Cc: Linux Kernel Mailing List
On Tue, 05 Jul 2011 19:42:18 -0400 (EDT) Peter Foley wrote:
> When IKCONFIG is built-in make oldconfig will cause the kernel to be
> relinked even if .config didn't change. This happens because of a
> config_data.gz dependency on .config. This patch changes the if_changed to
> a filechk so that config_data.h is only rebuilt when the contents
> have actually changed.
>
> Signed-off-by: Peter Foley <pefoley2@verizon.net>
Michal,
If this looks OK to you, please merge it.
Thanks.
> ---
> kernel/Makefile | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 2d64cfc..d06467f 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -125,11 +125,10 @@ targets += config_data.gz
> $(obj)/config_data.gz: $(KCONFIG_CONFIG) FORCE
> $(call if_changed,gzip)
>
> -quiet_cmd_ikconfiggz = IKCFG $@
> - cmd_ikconfiggz = (echo "static const char kernel_config_data[] __used = MAGIC_START"; cat $< | scripts/bin2c; echo "MAGIC_END;") > $@
> + filechk_ikconfiggz = (echo "static const char kernel_config_data[] __used = MAGIC_START"; cat $< | scripts/bin2c; echo "MAGIC_END;")
> targets += config_data.h
> $(obj)/config_data.h: $(obj)/config_data.gz FORCE
> - $(call if_changed,ikconfiggz)
> + $(call filechk,ikconfiggz)
>
> $(obj)/time.o: $(obj)/timeconst.h
>
> --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kernel: prevent unnecessary rebuilding due to config_data.gz
2011-07-06 15:33 ` Randy Dunlap
@ 2011-07-15 2:52 ` Peter Foley
2011-07-19 23:33 ` Michal Marek
1 sibling, 0 replies; 4+ messages in thread
From: Peter Foley @ 2011-07-15 2:52 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Peter Foley, Michal Marek, Linux Kernel Mailing List
On Wed, 6 Jul 2011, Randy Dunlap wrote:
> On Tue, 05 Jul 2011 19:42:18 -0400 (EDT) Peter Foley wrote:
>
> > When IKCONFIG is built-in make oldconfig will cause the kernel to be
> > relinked even if .config didn't change. This happens because of a
> > config_data.gz dependency on .config. This patch changes the if_changed to
> > a filechk so that config_data.h is only rebuilt when the contents
> > have actually changed.
> >
> > Signed-off-by: Peter Foley <pefoley2@verizon.net>
>
> Michal,
> If this looks OK to you, please merge it.
>
> Thanks.
>
> > ---
> > kernel/Makefile | 5 ++---
> > 1 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/kernel/Makefile b/kernel/Makefile
> > index 2d64cfc..d06467f 100644
> > --- a/kernel/Makefile
> > +++ b/kernel/Makefile
> > @@ -125,11 +125,10 @@ targets += config_data.gz
> > $(obj)/config_data.gz: $(KCONFIG_CONFIG) FORCE
> > $(call if_changed,gzip)
> >
> > -quiet_cmd_ikconfiggz = IKCFG $@
> > - cmd_ikconfiggz = (echo "static const char kernel_config_data[] __used = MAGIC_START"; cat $< | scripts/bin2c; echo "MAGIC_END;") > $@
> > + filechk_ikconfiggz = (echo "static const char kernel_config_data[] __used = MAGIC_START"; cat $< | scripts/bin2c; echo "MAGIC_END;")
> > targets += config_data.h
> > $(obj)/config_data.h: $(obj)/config_data.gz FORCE
> > - $(call if_changed,ikconfiggz)
> > + $(call filechk,ikconfiggz)
> >
> > $(obj)/time.o: $(obj)/timeconst.h
> >
> > --
>
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
Ping?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kernel: prevent unnecessary rebuilding due to config_data.gz
2011-07-06 15:33 ` Randy Dunlap
2011-07-15 2:52 ` Peter Foley
@ 2011-07-19 23:33 ` Michal Marek
1 sibling, 0 replies; 4+ messages in thread
From: Michal Marek @ 2011-07-19 23:33 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Peter Foley, Linux Kernel Mailing List
On Wed, Jul 06, 2011 at 08:33:29AM -0700, Randy Dunlap wrote:
> On Tue, 05 Jul 2011 19:42:18 -0400 (EDT) Peter Foley wrote:
>
> > When IKCONFIG is built-in make oldconfig will cause the kernel to be
> > relinked even if .config didn't change. This happens because of a
> > config_data.gz dependency on .config. This patch changes the if_changed to
> > a filechk so that config_data.h is only rebuilt when the contents
> > have actually changed.
> >
> > Signed-off-by: Peter Foley <pefoley2@verizon.net>
>
> Michal,
> If this looks OK to you, please merge it.
Thanks, merged to kbuild-2.6.git#kbuild.
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-19 23:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-05 23:42 [PATCH] kernel: prevent unnecessary rebuilding due to config_data.gz Peter Foley
2011-07-06 15:33 ` Randy Dunlap
2011-07-15 2:52 ` Peter Foley
2011-07-19 23:33 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox