public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <keith.busch@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@fb.com>,
	linux-api@vger.kernel.org, dm-devel@redhat.com,
	linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: Persistent Reservation API V2
Date: Thu, 20 Aug 2015 23:56:36 +0000 (UTC)	[thread overview]
Message-ID: <alpine.LNX.2.00.1508202317270.15930@localhost.lm.intel.com> (raw)
In-Reply-To: <1439360604-16192-1-git-send-email-hch@lst.de>

On Tue, 11 Aug 2015, Christoph Hellwig wrote:
> This series adds support for a simplified Persistent Reservation API
> to the block layer.  The intent is that both in-kernel and userspace
> consumers can use the API instead of having to hand craft SCSI or NVMe
> command through the various pass through interfaces.  It also adds
> DM support as getting reservations through dm-multipath is a major
> pain with the current scheme.
>
> NVMe support currently isn't included as I don't have a multihost
> NVMe setup to test on, but Keith offered to test it and I'll have
> a patch for it shortly.

Hi Christoph,

I wrote an nvme implementation and it seems to work as expected with your
pr-tests (minor modification to open an nvme target). While API appears to
work as designed, there are a few features of NVMe that are unreachable
with it. For example, NVMe can ignore existing keys when acquiring a
reservation in addition to registering a new key. NVMe can also specify
if whether or not a reservation should persist through power-loss.

Anyway, I don't think SCSI has these same options. Should this new IOCTL
API accommodate the common subset to maintain its simplicity, or make
it more expressive for all features? The more important question might
be if there are any users requiring these features, and I honestly don't
know that right now.

  parent reply	other threads:[~2015-08-20 23:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12  6:23 Persistent Reservation API V2 Christoph Hellwig
2015-08-12  6:23 ` [PATCH 1/5] block: cleanup blkdev_ioctl Christoph Hellwig
2015-08-12  6:23 ` [PATCH 2/5] block: add an API for Persistent Reservations Christoph Hellwig
2015-08-12  6:23 ` [PATCH 3/5] sd: implement the Persistent Reservation API Christoph Hellwig
2015-08-12  6:23 ` [PATCH 4/5] dm: refactor ioctl handling Christoph Hellwig
2015-08-12  6:23 ` [PATCH 5/5] dm: add support for passing through persistent reservations Christoph Hellwig
2015-08-17 19:13 ` Persistent Reservation API V2 Christoph Hellwig
2015-08-18 17:58   ` Jens Axboe
2015-08-20 23:56 ` Keith Busch [this message]
2015-08-21  6:59   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1508202317270.15930@localhost.lm.intel.com \
    --to=keith.busch@intel.com \
    --cc=axboe@fb.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox