From: Finn Thain <fthain@telegraphics.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Vivier <lvivier@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-m68k <linux-m68k@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/12] block/swim: Fix array bounds check
Date: Tue, 10 Apr 2018 11:10:10 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.21.1804101102420.8@nippy.intranet> (raw)
In-Reply-To: <CAMuHMdXC3d84tJLsr=mZx20qsF6ddvmNMSFOCY-xHmzqDF3qhQ@mail.gmail.com>
On Mon, 9 Apr 2018, Geert Uytterhoeven wrote:
> Looks like amiflop.c:find_floppy() needs a check, too?
>
AFAICS there is no array index bug in floppy_find() in amiflop.c.
The 'unit' array's size is FD_MAX_UNITS which is defined as 4 in
include/linux/amifd.h, and the array index is drive = *part & 3.
--
next prev parent reply other threads:[~2018-04-10 1:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 1:41 [PATCH 00/12] SWIM driver fixes Finn Thain
2018-04-01 1:41 ` [PATCH 02/12] m68k/mac: Fix SWIM memory resource end address Finn Thain
2018-04-09 12:51 ` Geert Uytterhoeven
2018-04-01 1:41 ` [PATCH 03/12] m68k/mac: Don't remap SWIM MMIO region Finn Thain
2018-04-09 12:54 ` Geert Uytterhoeven
2018-04-09 15:17 ` Luc Van Oostenryck
2018-04-10 1:35 ` Finn Thain
2018-04-10 2:38 ` Michael Schmitz
2018-04-01 1:41 ` [PATCH 04/12] m68k/mac: Place ISM IOP in bypass mode Finn Thain
2018-04-01 1:41 ` [PATCH 01/12] m68k/mac: Revisit floppy disc controller base addresses Finn Thain
2018-04-01 1:41 ` [PATCH 09/12] block/swim: Rename macros to avoid inconsistent inverted logic Finn Thain
2018-04-01 1:41 ` [PATCH 12/12] block/swim: Select appropriate drive on device open Finn Thain
2018-04-01 1:41 ` [PATCH 11/12] block/swim: Fix IO error at end of medium Finn Thain
2018-04-01 1:41 ` [PATCH 07/12] block/swim: Remove extra put_disk() call from error path Finn Thain
2018-04-09 13:11 ` Geert Uytterhoeven
2018-04-01 1:41 ` [PATCH 05/12] block/swim: Use HEDSEL bit in ISM mode register Finn Thain
2018-04-01 1:41 ` [PATCH 10/12] block/swim: Check drive type Finn Thain
2018-04-01 1:41 ` [PATCH 06/12] block/swim: Fix array bounds check Finn Thain
2018-04-09 13:08 ` Geert Uytterhoeven
2018-04-10 1:10 ` Finn Thain [this message]
2018-04-01 1:41 ` [PATCH 08/12] block/swim: Don't log an error message for an invalid ioctl Finn Thain
2018-04-09 13:14 ` Geert Uytterhoeven
2018-04-10 1:27 ` Finn Thain
2018-04-03 19:07 ` [PATCH 00/12] SWIM driver fixes Laurent Vivier
2018-04-03 22:53 ` Finn Thain
2018-04-03 23:32 ` Jens Axboe
2018-04-03 23:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.1804101102420.8@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=axboe@kernel.dk \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=lvivier@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox