From: Keith Busch <keith.busch@intel.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Keith Busch" <keith.busch@intel.com>,
"Matias Bjørling" <m@bjorling.me>,
willy@linux.intel.com, sbradshaw@micron.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
hch@infradead.org
Subject: Re: [PATCH v5] conversion to blk-mq
Date: Wed, 4 Jun 2014 12:52:20 -0600 (MDT) [thread overview]
Message-ID: <alpine.LRH.2.03.1406041246300.11244@AMR> (raw)
In-Reply-To: <538F68A9.50608@kernel.dk>
On Wed, 4 Jun 2014, Jens Axboe wrote:
> On 06/04/2014 12:28 PM, Keith Busch wrote:
> Are you testing against 3.13? You really need the current tree for this,
> otherwise I'm sure you'll run into issues (as you appear to be :-)
I'm using Matias' current tree:
git://github.com/MatiasBjorling/linux-collab nvmeq_wip_6
Is this the right one to use? Looks like a 3.15rc1+.
Also ... obviously that's the wrong diff from before. I didn't save my
file before creating the diff. Should have looked like this:
diff --git a/block/blk-mq.c b/block/blk-mq.c
index d10013b..d1b986c 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -105,7 +105,8 @@ static int blk_mq_queue_enter(struct request_queue *q)
__percpu_counter_add(&q->mq_usage_counter, 1, 1000000);
smp_wmb();
/* we have problems to freeze the queue if it's initializing */
- if (!blk_queue_bypass(q) || !blk_queue_init_done(q))
+ if (!blk_queue_dying(q) && (!blk_queue_bypass(q) ||
+ !blk_queue_init_done(q)))
return 0;
__percpu_counter_add(&q->mq_usage_counter, -1, 1000000);
next prev parent reply other threads:[~2014-06-04 18:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 20:55 [PATCH v5] conversion to blk-mq Matias Bjørling
2014-06-02 20:55 ` [PATCH v5] NVMe: " Matias Bjørling
2014-06-02 22:49 ` [PATCH v5] " Keith Busch
2014-06-02 23:06 ` Keith Busch
2014-06-03 13:56 ` Matias Bjørling
2014-06-03 20:12 ` Matias Bjorling
2014-06-03 22:23 ` Keith Busch
2014-06-03 22:27 ` Keith Busch
2014-06-04 9:16 ` Matias Bjørling
2014-06-04 18:28 ` Keith Busch
2014-06-04 18:42 ` Jens Axboe
2014-06-04 18:52 ` Keith Busch [this message]
2014-06-04 18:55 ` Jens Axboe
2014-06-04 20:01 ` Matias Bjorling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.03.1406041246300.11244@AMR \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m@bjorling.me \
--cc=sbradshaw@micron.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).