From: Keith Busch <keith.busch@intel.com>
To: "Matias Bjørling" <m@bjorling.me>
Cc: Keith Busch <keith.busch@intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
"Sam Bradshaw (sbradshaw)" <sbradshaw@micron.com>,
Jens Axboe <axboe@fb.com>, Ming Lei <tom.leiming@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-nvme <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v8] NVMe: convert to blk-mq
Date: Tue, 24 Jun 2014 15:47:11 -0600 (MDT) [thread overview]
Message-ID: <alpine.LRH.2.03.1406241531350.4699@AMR> (raw)
In-Reply-To: <CAOu_J6mz=eeimXAsQ0Mj=tya+eHpwUoiG69=XPWbSEuRO1AwjA@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1091 bytes --]
On Tue, 24 Jun 2014, Matias Bjørling wrote:
> On Tue, Jun 24, 2014 at 10:33 PM, Keith Busch <keith.busch@intel.com> wrote:
>> On Tue, 24 Jun 2014, Matias Bjorling wrote:
>>> Den 16-06-2014 17:57, Keith Busch skrev:
>>>>
>>>> This latest is otherwise stable on my dev machine.
>>>
>>> May I add an Acked-by from you?
>>
>> Totally up to Willy, but my feeling is "not just yet". I see the value
>> this driver provides, but I would need to give this to a customer and
>> hear their results before adding an "ack". It maybe a couple more weeks
>> before they'll be able to try it.
>
> I was hoping to get an OK before that, to make sure it is picked up
> for the 3.17 release.
>
> Should I pack it up in a specific way to help it along?
I think what you're doing is the right way to go. I trust you removed
the test code from your next iteration, and this does pass my tests on my
machine... I was just hoping to hear what some other people with better
macro level benchmarking abilities would say. So okay, you can put my
"Acked-by" on this, but I don't have all the performance numbers yet.
next prev parent reply other threads:[~2014-06-24 21:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 12:09 [PATCH v8] convert nvme driver to blk-mq Matias Bjørling
2014-06-13 12:09 ` [PATCH v8] NVMe: convert " Matias Bjørling
2014-06-16 15:57 ` Keith Busch
2014-06-16 16:49 ` Matias Bjorling
2014-06-24 19:19 ` Matias Bjorling
2014-06-24 20:33 ` Keith Busch
2014-06-24 21:18 ` Matias Bjørling
2014-06-24 21:47 ` Keith Busch [this message]
2014-06-24 21:57 ` Matias Bjørling
2014-06-13 13:27 ` [PATCH v8] convert nvme driver " Christoph Hellwig
2014-06-13 13:55 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.03.1406241531350.4699@AMR \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m@bjorling.me \
--cc=sbradshaw@micron.com \
--cc=tom.leiming@gmail.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox