From: Keith Busch <keith.busch@intel.com>
To: "Matias Bjørling" <m@bjorling.me>
Cc: willy@linux.intel.com, keith.busch@intel.com,
sbradshaw@micron.com, axboe@fb.com, tom.leiming@gmail.com,
hch@infradead.org, rlnelson@google.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v13] NVMe: Convert to blk-mq
Date: Tue, 30 Sep 2014 11:42:34 -0600 (MDT) [thread overview]
Message-ID: <alpine.LRH.2.03.1409301134580.4688@AMR> (raw)
In-Reply-To: <1412098195-30133-2-git-send-email-m@bjorling.me>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 624 bytes --]
On Tue, 30 Sep 2014, Matias Bjørling wrote:
> @@ -1967,27 +1801,30 @@ static struct nvme_ns *nvme_alloc_ns(struct nvme_dev *dev, unsigned nsid,
> {
...
> - ns->queue->queue_flags = QUEUE_FLAG_DEFAULT;
> + queue_flag_set_unlocked(QUEUE_FLAG_DEFAULT, ns->queue);
Instead of the above, you want
+ ns->queue->queue_flags |= QUEUE_FLAG_DEFAULT;
I only caught it because of the fun dm-mpath attempt with nvme and
blk-mq. Or maybe we don't want to include "QUEUE_FLAG_STACKABLE" right
now (part of the default flags) because it will kernel crash if you're
using dm-multipath with a blk-mq driver today.
Otherwise, looks great!
next prev parent reply other threads:[~2014-09-30 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 17:29 [PATCH v13] Convert NVMe driver to blk-mq Matias Bjørling
2014-09-30 17:29 ` [PATCH v13] NVMe: Convert " Matias Bjørling
2014-09-30 17:42 ` Keith Busch [this message]
2014-09-30 18:10 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.03.1409301134580.4688@AMR \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m@bjorling.me \
--cc=rlnelson@google.com \
--cc=sbradshaw@micron.com \
--cc=tom.leiming@gmail.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox