From: Meelis Roos <mroos@linux.ee>
To: Helge Deller <deller@gmx.de>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
jejb@parisc-linux.org, mpatocka@redhat.com,
kirill.shutemov@linux.intel.com, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
John David Anglin <dave.anglin@bell.net>
Subject: Re: [PATCH] parisc: mm: Fix a memory leak related to pmd not attached to the pgd
Date: Mon, 20 Jul 2015 22:28:56 +0300 (EEST) [thread overview]
Message-ID: <alpine.LRH.2.11.1507202228030.21509@math.ut.ee> (raw)
In-Reply-To: <55A408F5.601@gmx.de>
> Hi Christophe,
>
> On 13.07.2015 11:32, Christophe JAILLET wrote:
> > Commit 0e0da48dee8d ("parisc: mm: don't count preallocated pmds")
> > introduced a memory leak.
> >
> > After this commit, the 'return' statement in pmd_free is executed in all
> > cases. Even for pmd that are not attached to the pgd.
> > So 'free_pages' can never be called anymore, leading to a memory leak.
>
> That's really great!!! Thanks for spotting this!
>
> I assume this fixes the leak which killed our debian buildds with OOM
> after an uptime of 1-4 days and which only happened since kernel 4.0.
> Meelis Roos reported the issue already in this thread:
> http://marc.info/?l=linux-parisc&m=142999113232154&w=2
Yes, the patch that is merged in 4.2-rc3 fixed my RP3410 with 1G RAM.
--
Meelis Roos (mroos@linux.ee)
next prev parent reply other threads:[~2015-07-20 19:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 9:32 [PATCH] parisc: mm: Fix a memory leak related to pmd not attached to the pgd Christophe JAILLET
2015-07-13 9:46 ` Kirill A. Shutemov
2015-07-13 12:48 ` Mikulas Patocka
2015-07-13 18:52 ` Helge Deller
[not found] ` <55A4095E.4060200@gmx.de>
2015-07-14 11:52 ` John David Anglin
2015-07-14 12:01 ` John David Anglin
2015-07-20 19:28 ` Meelis Roos [this message]
2015-07-14 11:09 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.11.1507202228030.21509@math.ut.ee \
--to=mroos@linux.ee \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dave.anglin@bell.net \
--cc=deller@gmx.de \
--cc=jejb@parisc-linux.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox