From: Meelis Roos <mroos@linux.ee>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org
Subject: Re: [PATCH v1 0/4] sparc/PCI: VGA resource and other fixes
Date: Thu, 24 May 2018 11:34:26 +0300 (EEST) [thread overview]
Message-ID: <alpine.LRH.2.21.1805241133450.13830@math.ut.ee> (raw)
In-Reply-To: <20180522130217.GA161672@bhelgaas-glaptop.roam.corp.google.com>
> [+cc sparclinux, sorry I missed this first time around]
> > sparc/PCI: Use dev_printk() when possible
This patch causes compile errors for me:
CC arch/sparc/kernel/pci.o
In file included from ./include/linux/pci.h:31:0,
from arch/sparc/kernel/pci.c:18:
arch/sparc/kernel/pci.c: In function ‘pcibios_enable_device’:
arch/sparc/kernel/pci.c:754:53: error: ‘old_cmd’ undeclared (first use in this function)
pci_info(dev, "enabling device (%04x -> %04x)\n", old_cmd, cmd);
^
./include/linux/device.h:1384:58: note: in definition of macro ‘dev_info’
#define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg)
^
arch/sparc/kernel/pci.c:754:3: note: in expansion of macro ‘pci_info’
pci_info(dev, "enabling device (%04x -> %04x)\n", old_cmd, cmd);
^
arch/sparc/kernel/pci.c:754:53: note: each undeclared identifier is reported only once for each function it appears in
pci_info(dev, "enabling device (%04x -> %04x)\n", old_cmd, cmd);
^
./include/linux/device.h:1384:58: note: in definition of macro ‘dev_info’
#define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg)
^
arch/sparc/kernel/pci.c:754:3: note: in expansion of macro ‘pci_info’
pci_info(dev, "enabling device (%04x -> %04x)\n", old_cmd, cmd);
^
scripts/Makefile.build:312: recipe for target 'arch/sparc/kernel/pci.o' failed
--
Meelis Roos (mroos@linux.ee)
next prev parent reply other threads:[~2018-05-24 8:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 0:30 [PATCH v1 0/4] sparc/PCI: VGA resource and other fixes Bjorn Helgaas
2018-05-22 0:30 ` [PATCH v1 1/4] sparc/PCI: Request legacy VGA framebuffer only for VGA devices Bjorn Helgaas
2018-05-22 0:30 ` [PATCH v1 2/4] sparc32/PCI/LEON: Converge device enable path Bjorn Helgaas
2018-05-22 0:30 ` [PATCH v1 3/4] sparc32/PCI/PCIC: " Bjorn Helgaas
2018-05-22 0:30 ` [PATCH v1 4/4] sparc/PCI: Use dev_printk() when possible Bjorn Helgaas
2018-05-22 13:02 ` [PATCH v1 0/4] sparc/PCI: VGA resource and other fixes Bjorn Helgaas
2018-05-24 8:34 ` Meelis Roos [this message]
2018-05-24 13:34 ` Bjorn Helgaas
2018-05-30 16:45 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1805241133450.13830@math.ut.ee \
--to=mroos@linux.ee \
--cc=davem@davemloft.net \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox