From: Alan Maguire <alan.maguire@oracle.com>
To: Marco Elver <elver@google.com>
Cc: linux-kernel@vger.kernel.org, brendanhiggins@google.com,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
alan.maguire@oracle.com, frank.rowand@sony.com,
skhan@linuxfoundation.org
Subject: Re: [PATCH] kunit: Add missing newline in summary message
Date: Fri, 17 Apr 2020 11:03:43 +0100 (BST) [thread overview]
Message-ID: <alpine.LRH.2.21.2004171103160.32364@localhost> (raw)
In-Reply-To: <20200416114256.226329-1-elver@google.com>
On Thu, 16 Apr 2020, Marco Elver wrote:
> Add missing newline, as otherwise flushing of the final summary message
> to the console log can be delayed.
>
> Fixes: e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")
> Signed-off-by: Marco Elver <elver@google.com>
Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
Thanks for finding/fixing this!
Alan
> ---
> lib/kunit/test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/kunit/test.c b/lib/kunit/test.c
> index 7a6430a7fca0..ccb2ffad8dcf 100644
> --- a/lib/kunit/test.c
> +++ b/lib/kunit/test.c
> @@ -93,7 +93,7 @@ static void kunit_print_ok_not_ok(void *test_or_suite,
> * representation.
> */
> if (suite)
> - pr_info("%s %zd - %s",
> + pr_info("%s %zd - %s\n",
> kunit_status_to_string(is_ok),
> test_number, description);
> else
> --
> 2.26.1.301.g55bc3eb7cb9-goog
>
>
next prev parent reply other threads:[~2020-04-17 10:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 11:42 [PATCH] kunit: Add missing newline in summary message Marco Elver
2020-04-17 2:55 ` David Gow
2020-04-17 10:03 ` Alan Maguire [this message]
2020-04-22 11:05 ` Marco Elver
2020-04-22 19:37 ` Brendan Higgins
2020-04-22 19:35 ` Brendan Higgins
2020-04-23 22:07 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.2004171103160.32364@localhost \
--to=alan.maguire@oracle.com \
--cc=brendanhiggins@google.com \
--cc=elver@google.com \
--cc=frank.rowand@sony.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox