From: Hugh Dickins <hughd@google.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
bhalevy@tonian.com, dhillf@gmail.com
Subject: Re: + mm-mmapc-replace-find_vma_prepare-with-clearer-find_vma_links.patch added to -mm tree
Date: Wed, 12 Sep 2012 16:53:54 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.00.1209121649430.15738@eggly.anvils> (raw)
In-Reply-To: <alpine.DEB.2.00.1209121618520.12415@chino.kir.corp.google.com>
On Wed, 12 Sep 2012, David Rientjes wrote:
> On Wed, 12 Sep 2012, Hugh Dickins wrote:
> > > that we can't fix it all up to use
> > > uninitialized_var() so this is handled the proper way?
> >
> > I do prefer to avoid it when we can, some reasons given below.
>
> It's easily silenced with __maybe_unused.
I'm not necessarily against __maybe_unused, but I am surprised that it
should have an effect here: I think of that as a tool for a different
job, and would be misleading in this context.
> > Given David's preference for no warning, mine for no uninitialized_var,
> > and Linus's for renaming BUG() to I_AM_A_MORON() to discourage its use
> > in the first place: copy_vma() seems a prime candidate for returning
> > failure to mremap instead of crashing the system.
> >
> > Signed-off-by: Hugh Dickins <hughd@google.com>
>
> Tested-by: David Rientjes <rientjes@google.com>
Thanks!
Hugh
prev parent reply other threads:[~2012-09-12 23:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120816200105.C14EA1E0048@wpzn4.hot.corp.google.com>
2012-09-11 17:55 ` + mm-mmapc-replace-find_vma_prepare-with-clearer-find_vma_links.patch added to -mm tree David Rientjes
2012-09-11 18:24 ` Hugh Dickins
2012-09-12 1:44 ` David Rientjes
2012-09-12 18:52 ` Hugh Dickins
2012-09-12 23:25 ` David Rientjes
2012-09-12 23:53 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1209121649430.15738@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=bhalevy@tonian.com \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox