From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9873C433E9 for ; Tue, 12 Jan 2021 00:45:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AC4522D6D for ; Tue, 12 Jan 2021 00:45:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728018AbhALApU (ORCPT ); Mon, 11 Jan 2021 19:45:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726655AbhALApQ (ORCPT ); Mon, 11 Jan 2021 19:45:16 -0500 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F8B0C061575 for ; Mon, 11 Jan 2021 16:44:35 -0800 (PST) Received: by mail-ot1-x333.google.com with SMTP id x13so703002oto.8 for ; Mon, 11 Jan 2021 16:44:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=bI5isbHsIMG1DeC1iKJ9N4yCisPBZV9Gz2XLsNHbC2k=; b=mwRiQ0k3oRDBBm+/k4IoixgEDt7lVzrL9vj+XrAcjPAje6+iJqSyN/uzdnU8gh2L/G fNSARI+K1hwhOcRMCYCW+y2JJRldNJgn/XXkoDPp8mZqYc9vMxNmRdxDMEd9QhNpzN0b 8Y8fnImvsHXN/L8kUTrXnQVYw4kx8PO+RZj/6jG/RFbeSPSa6VEPn08h6s83yA8G1hCA lfU3qtbCgtcEN8yGyJW7olfsaHSdVnKx3C8Gz1SHtNWsZZ4F4SuzVu3O4fkDp466Ab2Z ykXmx/CeaxEVAgCWue9htyItW8EMkTXscG0mULVJpwWUpESKWijTDuXfpguELSVEtA0B F8fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=bI5isbHsIMG1DeC1iKJ9N4yCisPBZV9Gz2XLsNHbC2k=; b=SlYFjiC8J65fiIui51WZWeAJ39Ml8RESdZ2uRkVbQPo7DiVEYMAd25XowmYHxzC6Q7 5MPr1HpCCtUkbPUuh7dTtN1NOZmqJTzZIW9oPvygpFXi2oaMRaYLPVpfswAYr9mojci0 DxVzLSnB+l7Hk5RsgSrQF30fLQVbH9kNe6xH2Cmv7GCt951J0ynuoQ0zh4l8XEvR0tVx FGh86gNGtfTKIOcwJ0uoF52vialqUVZ8crWwS9xZ4GAD+8Od/s6faqFu/LHgXUbgLBgB vHXRYvB3Tx64K2sY+wLt5XnRMo/vIFBUeZVrIlc4oC+srgRSi95JuVQ7OZVrP0AG4lxd NZEw== X-Gm-Message-State: AOAM530qNVFxBPt4340VR4AMBftgwQtt8CEB6OLe//6qwh/W0uQZQBPC vgTyBmNXfZmRx3MLQnUzQS4oRQ== X-Google-Smtp-Source: ABdhPJxH59M61dNaafSElROY/MJR04BTorQ9DyF+MbdXoWzA+l2M4L5OIw6uCeRiryKJWBJtv7mkvA== X-Received: by 2002:a9d:453:: with SMTP id 77mr1153492otc.91.1610412274718; Mon, 11 Jan 2021 16:44:34 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id e17sm312549otf.32.2021.01.11.16.44.33 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 11 Jan 2021 16:44:34 -0800 (PST) Date: Mon, 11 Jan 2021 16:44:21 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Saravana Kannan cc: Hugh Dickins , "Rafael J. Wysocki" , Thierry Reding , Jonathan Hunter , Greg Kroah-Hartman , Vincent Huang , "Jason A. Donenfeld" , Andrew Duggan , Lucas Stach , Linux Kernel Mailing List , Linux PM Subject: Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Jan 2021, Saravana Kannan wrote: > On Mon, Jan 11, 2021 at 3:42 PM Hugh Dickins wrote: > > On Mon, 11 Jan 2021, Saravana Kannan wrote: > > > > > > I happen to have an X1 Carbon (different gen though) lying around and > > > I poked at its /sys folders. None of the devices in the rmi4_smbus are > > > considered the grandchildren of the i2c device. I think the real > > > problem is rmi_register_transport_device() [1] not setting up the > > > parent for any of the new devices it's adding. > > > > > > Hugh, can you try this patch? > > > > Just tried, but no, this patch does not help; but I bet > > you're along the right lines, and something as simple will do it. > > Did you see this patch change the organization of devices under /sys/devices/? > The rmi* devices need to be under one of the i2c devices after this > patch. Is that not the case? Or is that the case, but you are still > seeing suspend/resume issues? Now that I look, yes, that patch has moved the directory /sys/devices/rmi4-00 to /sys/devices/pci0000:00/0000:00:1f.4/i2c-6/6-002c/rmi4-00 But I still see the same suspend issues despite that. Hugh