From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755981Ab0EaPTS (ORCPT ); Mon, 31 May 2010 11:19:18 -0400 Received: from www.telegraphics.com.au ([204.15.192.19]:56179 "EHLO mail.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753840Ab0EaPTR (ORCPT ); Mon, 31 May 2010 11:19:17 -0400 Date: Tue, 1 Jun 2010 01:19:06 +1000 (EST) From: Finn Thain To: David Miller cc: joe@perches.com, geert@linux-m68k.org, p_gortmaker@yahoo.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org Subject: Re: [PATCH] mac8390: change an error return code and some cleanup, take 4 In-Reply-To: <20100531.081412.27799681.davem@davemloft.net> Message-ID: References: <1275318493.6503.206.camel@Joe-Laptop.home> <20100531.081412.27799681.davem@davemloft.net> User-Agent: Alpine 2.00 (OSX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 May 2010, David Miller wrote: > From: Joe Perches > Date: Mon, 31 May 2010 08:08:13 -0700 > > > There are many uses of KERN_DEBUG that are reasonable to have always > > enabled. > > Doubtful. > > pr_debug() makes a ton of sense as currently implemented. It's for > messages that we want both compile time and run-time control over. > > The case we have here in mac8390 seems like it should stay as pr_info(). > Because 1) it's already controlled by a run-time knob so controlling it > even further is confusing and 2) the message is "informative", it lets > the user know a feature cannot be enabled, thus pr_info(). If that is true in general, then ei_debug itself becomes questionable. In the case of mac8390 at least, I'm certainly leaning toward changing the pr_info (conditional on ei_debug) to pr_debug (unconditional). Finn