From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9ED037F72C for ; Fri, 17 Jul 2026 19:41:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784317263; cv=none; b=k9pfMEeo8oPhKRaNLTx6tBlLGmLrHB9Ot3MTujblZmEWq9qy7zfUp/obg18jFSdlMvemJZ7ZaDUWE1MDXhTuoOYnyG2qSWCB0Bsw4Kp6WgoG/Ulj9t+jQIZfo0A6ourX7WxSlLRnjUYkK9KQsU5ndkOVg7/3YdNLEQJlvMjILTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784317263; c=relaxed/simple; bh=32n7+drnmjsHOwmKp37FgDZV8uI0SFCc7HoxHLrBYas=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sX3FxMR0M8haV9BMb2DanGkEZFh+snHBIWD2/vFIR5eFYaa+LfnzZa4ant9492PznirfezqhX9+Ss3A9G+pWo1SookWouNGh08VDmIvbNGqBETiACNT4acN8roLoqmIuzxcp/HiAnPWNS94APIaGfcuKtpMz5ixw2ZXFGxRqLBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=SYU85b/0; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="SYU85b/0" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-92edb12cdf2so306952685a.3 for ; Fri, 17 Jul 2026 12:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1784317261; x=1784922061; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Cc8aVZtebMWgQf9o/5yCOKG8fzMb7f5xhxINPxPhrtE=; b=SYU85b/0hzlz/OKGO4pCzU02jnBe1KGkcOFsOnWdfyxyZap/FbP3jyHpBH/92Bcai2 4EzZyVOJXkObOybtS9A/t4U+HruzT4EM8cj7nbNh+e3fcQS/oy5S8h/IL//Q2neK+go4 yISiZ+qMo+JUiY3CEBdcL/7wG4Trr4i12lTDbGnJVb7nN4JoawGXQZ4ouUIDgpupI0+M Cc2262GzbBGHjahFmLSm0gfnp5R87zpzcs3xNBBxjiefS0iV2JDkOXmMA6cgx4iFs/zI MAD/v4UNm+m+6iy3zFnFPsxw/p5r0saeR3j8Qs2DwXrsB1Lar2KyhZ3wHckeciqvQxI8 +RQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784317261; x=1784922061; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Cc8aVZtebMWgQf9o/5yCOKG8fzMb7f5xhxINPxPhrtE=; b=Wtgm1wdnQA+vLq7/2/I+gmtN0KUofzG7Y75A1ABb6utJlt71TXmuo/JDiyCnPpOb4r vLq4eNYJmdUguCF7O17BYEMAQK7i5gAQE4U3RpSd0v6m3qR30jN7GGIvb9zq7XYi8/og u27JtZLx/H6VY3hW9GCNopI3s2WK63U5gefP7y/Y0eknVj4ssjVY1p+KmW5MKdOClsH1 /6qZACnokLbAarNKsbE2yzF8jnvkejxIOsfBzR4AhiOm27NtVi3+2c4OdNearMu8Y8lS Q7tbdPrloniYnADyPTyPAeIc3JjON42tOw1AMOxcYicFihLwEhWsezDYTZz2C0ud9NTF xh2g== X-Forwarded-Encrypted: i=1; AHgh+RpBh1cUPmE6b6FTBq88LdrOmP+99InneY8oIANqOJjPfzcEUobnfa36mhkih0WTYgDa9ynnCKypHUpLbA0=@vger.kernel.org X-Gm-Message-State: AOJu0Yyh5QE98fP1yKFlOE8ZgouCHhOwavJe29kVu7uJWjnwzL6e3n2u uB7mGiapUDexsW9EjeoixpbFflygkmZ1HBNz17wx8X2ZMXtQlvXVxzXXBqOvnO0UsBY= X-Gm-Gg: AfdE7cnWts+F4FPKBbL2nRndHyPB08BhpMB9mfX/+zp1s2OAI14wSS7qmoExbnQEAN3 sOyZQ2yjgg/gMzaEMkuvAyYUJs/4qVm42M3aEdWHAixlk6jqwWO4iFm0cuda6U7wdVUt5+9+qmD DmqIGT1vJ1GdgEglqFmTr25L134lKU64rnGVB/sFeaLzKO5cRFuoo8dFBu/mWr/xMeln/WKapJM z/SUoeXpOLUg9DCLt/0nNsqgVGEh0CfPVF3gMFa77AFGj8lUxEFTtfY3ti55GZ4p7pGUKIs3z87 dn/x+96P2yGmoub/uGPXGScJYVtzJXzg4xbkINJHCecigzwbhsZPV6D6Nh0OvYOho7jI3XaQxKa k5u7vnQY+yn887qwzCahzC66orw1v4fJBWcNwAdWybP8qWFla8/5eSWW36+XW7cKeTMmq0j8jCz UqthS85Dl3rOv40lahueGCTDT6Ka7Fgw== X-Received: by 2002:a05:620a:a197:20b0:92e:c116:bef7 with SMTP id af79cd13be357-930b4315f1cmr311099685a.84.1784317260004; Fri, 17 Jul 2026 12:41:00 -0700 (PDT) Received: from plex ([71.181.43.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-930b52dff03sm230279385a.9.2026.07.17.12.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:40:59 -0700 (PDT) Date: Fri, 17 Jul 2026 19:40:58 +0000 From: Pasha Tatashin To: Jason Gunthorpe Cc: Pasha Tatashin , David Matlack , kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Adithya Jayachandran , Alexander Graf , Alex Williamson , Bjorn Helgaas , Chris Li , David Rientjes , Jacob Pan , Jonathan Corbet , Josh Hilke , Leon Romanovsky , Lukas Wunner , Mike Rapoport , Parav Pandit , Pranjal Shrivastava , Pratyush Yadav , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Vipin Sharma , William Tu , Yi Liu Subject: Re: [PATCH v7 01/12] PCI: liveupdate: Set up FLB handler for the PCI core Message-ID: References: <20260710212616.1351130-1-dmatlack@google.com> <20260710212616.1351130-2-dmatlack@google.com> <178431652443.189683.17611165218179620081.b4-review@b4> <20260717193055.GD699082@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260717193055.GD699082@nvidia.com> On 07-17 16:30, Jason Gunthorpe wrote: > On Fri, Jul 17, 2026 at 07:28:44PM +0000, Pasha Tatashin wrote: > > On Fri, 10 Jul 2026 21:26:04 +0000, David Matlack wrote: > > > diff --git a/drivers/pci/liveupdate.c b/drivers/pci/liveupdate.c > > > new file mode 100644 > > > index 000000000000..899758883dd5 > > > --- /dev/null > > > +++ b/drivers/pci/liveupdate.c > > > @@ -0,0 +1,155 @@ > > > [ ... skip 50 lines ... ] > > > +#include > > > + > > > +/** > > > + * struct pci_flb_outgoing - Outgoing PCI FLB object > > > + * @ser: Pointer to the preserved struct pci_ser. > > > + * @block_set: The KHO block set holding the outgoing devices. > > > > AFAIK, these should be aligned after column: > > @ser: Pointer to ... > > @block_set: The KHO block ... > > Gosh I hope not, I never do that. The horizontal alignment is such a > PITA to maintain. Agreed. I just see that everywhere, so I thought it was the rule. If not, that is great; I hate them myself. > > Jason