From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 314262EA468 for ; Sun, 2 Aug 2026 19:42:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785699762; cv=none; b=BK+KNpLICNsVZ5W+ST1cDbmcNih4EQrmPdVzm0lko2utBmvQ6JdwOV4KVRleJmposxDDKBzDUkiIsN80HcidsvOAe/g+C50rXwfp082VcL0A2o61kj1oIehO8TX5MWMH985Yyr9XajHaKCh07O4oo6NhwuvcsVTXtpOTfKZAmd8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785699762; c=relaxed/simple; bh=GFvSZCbt78h2UO5NY9vbL6OkTmUM1o3SbWFju9pJroY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FiYB/+uSxnuAWy/Y8CxZeFC9OR1IbjG6NE+CK8j78nEogkWtfWnCJZsIlyVtJnGq1cq41iCCJO9oSbVILdotmISFdT2MtHpD6ujr2adOtHhDlg+rUd3EqLsHgQif9QErN/GFbuIxhYdPg5tnfdTddwBTkciKwrrjmgY+qz1I62U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S7yeVaWu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S7yeVaWu" Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id 527971F000E9; Sun, 2 Aug 2026 19:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785699760; bh=03/hmg3yofIYdmJNnB7xJK1irOaxad7yR41seOTEHxI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=S7yeVaWuCq+k1GMLnItpLZcBt/neIGiQFKqi0ppti/mWhr5t3NBF37TRChk0Hp3EU ZeFVqFJjBx2T/gU+X7GK+LCa/PkQC1FQvSfbca728wkcvAe/X5/zgHPSeAPeP6KqQx sIzLxd7OPvcojTHb8gBlSUAXWKvA6kTokts0oQHT4nwxIsUHbKKkC8DYcqTCZkPBsX UCvJhKaKRUzFQEzW0+Bkhcj1k0NO1J7NcqpqxvYRgK3mdyhzuVYCFsKPPVgxBinEmQ E45cne4YdGlp8PEjAUMA93HyfSYzwFHZgkqlYHLmEGCuZvMlCdvX59X+HJJNCjBnLl GGEtlIvoM/MkQ== Date: Sun, 2 Aug 2026 21:40:02 +0200 From: Nicolas Schier To: Julian Braha Cc: akpm@linux-foundation.org, arnd@arndb.de, ojeda@kernel.org, tglx@kernel.org, gary@garyguo.net, thomas.weissschuh@linutronix.de, aliceryhl@google.com, leitao@debian.org, dianders@chromium.org, linux.amoon@gmail.com, oleg@redhat.com, peterz@infradead.org, andreas@gaisler.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nohz: replace dead select with choice default Message-ID: References: <20260801160140.2391000-1-julianbraha@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260801160140.2391000-1-julianbraha@gmail.com> On Sat, Aug 01, 2026 at 05:01:40PM +0100, Julian Braha wrote: > 'select' does not work on config options in a 'choice', so currently the > 'select VIRT_CPU_ACCOUNTING_GEN' for NO_HZ_FULL is dead, with the choice > option VIRT_CPU_ACCOUNTING_GEN only being enabled when NO_HZ_FULL=y because > the other choice members depend on NO_HZ_FULL=n. > > Let's remove the dead select, and encode this relationship as a default of > the choice, instead. > > This dead select was found by kconfirm, a static analysis tool for Kconfig. > > Signed-off-by: Julian Braha > --- > init/Kconfig | 1 + > kernel/time/Kconfig | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > Thanks! Reviewed-by: Nicolas Schier