From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37D523B8BA4 for ; Tue, 4 Aug 2026 12:11:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785845480; cv=none; b=pDwLeFJRaXDP797mgg4QESASMVGCRfZ3O3/A2cvskQKiPE5CQbMYkJaFQRX++Z9xQdbfgxHLPFh+wfardIX1oJYbrwQlkD4gwwN766SKqcatZqOjP6L8W5DAW/mbpDetycHiVfE9A4qrlS3OVVf+btcr97OiP4wTvWTaFml7jOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785845480; c=relaxed/simple; bh=0LyZ74u2q1qi1dmfzlWBIuWO4q5Tgz2kSM6W13q2vbk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pLxTPmZZzp5k6RkqxvlA67ar51o+WJQgZI2V9uScvFPtT5kHIfdFLG3nql+ky76jJ9kmcBx/Y3g+QX+QLKqK5aSaKIumenn40grzvkViQHzTDSxLZ8C6fok+LpVz08QeAqzIcHQQNGsHBH8Ajl5+5oPVGVRPrzolvSvhxlYSKt4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aPjeZh6n; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aPjeZh6n" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38dfe7eb825so3375607a91.0 for ; Tue, 04 Aug 2026 05:11:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785845476; x=1786450276; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=6+Tse4pvOy70inx0hTOXqXvXU4gcfDFBrlYrB+8tgIk=; b=aPjeZh6n+GVn47Y8Bpdats/vOlQ4dBCkuJgDXH9JRmwe7np07SQHWG9kz37uC1imu8 Zvai90aJT7iEAqcWUKtS1u0nY47+geTUNYa29ix5jafBmthNb8p1xO9p9vT5hlihtHpV ctuqaccCftfP/ou9sqNCm6BoLaeX0OsLAgUxd7WjF9kAurASoKKTvrhrI52ePbzAMU51 AUOp/T/5+yw0C2mZsQQ6+ScQowNqrY5s29k5ly071Yt6+6MCa9ef5Wu9cyF9fuwrv6Bd +XMda9xKE/ShNkVq++/k9werV5+q1VROlqdEmov4jChTV9XrfCimRpb2RWrXix9vQ50x X7wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785845476; x=1786450276; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6+Tse4pvOy70inx0hTOXqXvXU4gcfDFBrlYrB+8tgIk=; b=IcbsVHu3KYFA8aTOzNwxkbi5cUGuKhVGJlKAMBE/6KQXS6MKRMd3KgCcTVNoRMGb83 PENoO8Bz+8vLs6Y+zgSTbgtjvcCWKAi+MLp7ThiOCUyFobEsnt71ZOUSctSAGly8DClH oV7m55f7mvwk9tVk7vE7grklBhhx7x3I3RoRr/2XkZX36q/1zuGTjgjsE25RiKocolWa 1TmbPC42J2JsVJcGS2kECIQdg3np09zLD4empV92T4W6FkgSDhA8WuFJUF/EVHrkImxu dKC5Zp/F9TLZPSV7Q5585CB9co4YoIy992jLsXAnRdXwqV7/9+i8y7ZD+VKRp1Uxg5JN rO9g== X-Forwarded-Encrypted: i=1; AHgh+Rr7Wvz0dh3JibBtuJG6OfbrECcRUYLF2mE1klRGLMLr/609Ck6CR198zXCE9ePDG3MOrs0GfbNEJfC/eus=@vger.kernel.org X-Gm-Message-State: AOJu0YwGcVM6JFx7RA3AqKx2NepQkWF6PQR8knl8xG0j6DcWGr9CPnrM YtigJmP8PV55Jr2kB/pkuOzuPLQTYfFg3IVLAyAtYmvLtbI3MmlqlzL1 X-Gm-Gg: AR+sD13NQwwqQFowq1+sKGRZAK3Xm7aZBoeOi8Yfw2cWgJaaSRcXpek/h0aa2HQeCh3 4KXwAJb7HBVH6Zu0AWtKsSUc2zKB2+MmOR2bODy9OMx8nSM6+/TpzpYqMywi1aepyHpGgQ6Uqaa 4q22dG2eMNjS0Apg63E1QHgrdRYCB3YPQqVvjDvyKxoyAOrtMDQ3not1nOgaFeQUj3FRB5MGseZ zdswbXdovSNZXuZvMrozC1zItA9uDKfzwWJFH3ZDP1KNP68e2l8oU20q8vA0EIrgcA1estBaPg/ KQgu6XvCUmYQLHs5FmHShJe+8R4uzsnuWxWFmsCwmXTsXk4PbIRWYyYVnEhWfL6wzP82JcrVJup lprvaQjvb9eGQbFF0QLqX4xZ0zAnMBezi7jOE9ynjiKEWeGAXhzIkPisYoKcdmoMhA7mnT0v8Q8 Fb+m+kfFao9IneK0chM5iiO66Jib7NEDEjR2c0G99a9L/60+FS7EOhS28tr4EKCHSu X-Received: by 2002:a17:90a:e70f:b0:38d:f1a4:1116 with SMTP id 98e67ed59e1d1-38fbc4f84c0mr12030932a91.33.1785845476337; Tue, 04 Aug 2026 05:11:16 -0700 (PDT) Received: from localhost ([172.216.252.8]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fec1209ebsm1252691a91.9.2026.08.04.05.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 05:11:15 -0700 (PDT) Date: Sat, 1 Aug 2026 00:21:43 +0300 From: Dan Carpenter To: Myeonghun Pak Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ijae Kim Subject: Re: [PATCH] staging: rtl8723bs: disable SDIO function on block size failure Message-ID: References: <20260731161710.44828-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260731161710.44828-1-mhun512@gmail.com> On Sat, Aug 01, 2026 at 01:17:10AM +0900, Myeonghun Pak wrote: > sdio_init() enables the SDIO function before configuring the block > size. If sdio_set_block_size() fails, the function jumps to the release > path and returns the error without disabling the SDIO function. The > caller then frees the dvobj directly, so the enabled SDIO function is > left active on that probe failure path. > > Disable the SDIO function before releasing the host when block size > configuration fails. > > This issue was identified during our ongoing static-analysis research while > reviewing kernel code. > > Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") > Co-developed-by: Ijae Kim > Signed-off-by: Ijae Kim > Signed-off-by: Myeonghun Pak > --- Looks good. Reviewed-by: Dan Carpenter regards, dan carpenter