From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F2223B2FC8 for ; Tue, 4 Aug 2026 12:11:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785845485; cv=none; b=OF8x21xwIHkS+1yI23yNPYY+N1YaQcfsnhhUAH2rsGzM8Vbu+ns385J6HDVkr7MhrBuYCLzC93drTCdAUrnVPQYczWqccS3yWM7V1egbbOOmz6b5StAmiltCm0V6JmEbYnbKSr1rtYIJNWTMvfDxHYsEaPQNuDtCUtDiJPhwxuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785845485; c=relaxed/simple; bh=gdvqsoZDauSKbuK8JVk7/FuygUkQSM+flJUBcR3la6c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s82LR61T6IKxGxGaaYED42T8fiKvTE6uBOcbwpU/NphtpyCZgGy0oHN8lw9G1t+mJUWo8ASKjtfC5MIBpkoeHNzXEqzwOPBvEvwc958UMAWasqOS52TSW7G1kawy0mOBalX58LmY4rer6E0krmTBx3wtlI7JwCmINaeCJLlkm8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JP7aqXXV; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JP7aqXXV" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-8487214ad2bso6294260b3a.1 for ; Tue, 04 Aug 2026 05:11:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785845483; x=1786450283; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JkdEkpDmK/siHWbsxxW9Vf3NMr3wTKTZgRi6uSb9CHk=; b=JP7aqXXVrFiXLLFIGclK+JTMvmRuEzgtYIiXM2EPqipPunVyuJvODnMRArm97bqZOL pgg/SToSvl6vmyNg8rdVOYUeZiuE5B0pf86eNLha9PiNncDCc9XgmXPp2u8SyGAkyf7c gyQe59I//di7nFQSVIAm2Sug+S4J9W/l0/+Mx3pru2qvX8JyBQm+Y/iHX0UG3z8YbnZO NkO8FNFNAhxZD+D2Fw7FviLNcJRSkTn+a0mW9WAq1IHSj/YNBwL//hHK/seRoQiAQUKi dYeZuUiKVbt2N6dwp/kvn0OqWcV1PbSH/5dPHN4+chSIrDi90jybVyIFdMK/dEMncIas ca1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785845483; x=1786450283; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JkdEkpDmK/siHWbsxxW9Vf3NMr3wTKTZgRi6uSb9CHk=; b=q+YPUjKnkjgZWYSbO4DBYJQ+VfY/M9tIvwT3cy+cznj2xYCKybtt3jikohoC4aSWrB x/UNiUFTfYDFmmJUMSYfENIXHxbUFT+dCIEdapULKDNgkeamFJMjhmuN2LtnAuT6M3Cf Lf7VpknDRtuBoGzI6qnpve93s/9WaI8Yn2WKY/t7D4AxVOjsPgt99BKp/uCjWr2BXsth 8OF1RnEy16R/1s3N3jNE8Ez1+wL72ZVuQOqlw+QUtYqEuSvNkIiwQssnLPIximHzHskW pFxLalvP/7Ly0NUwkZO2v3RMjw65TcyoEyWnjgGNz+i/B39dvXpwwPQhKHPSTA7k/s/M Ckbg== X-Forwarded-Encrypted: i=1; AHgh+Rp+DQJjwnF7TrEgSa3XLPOeRSck0IWcnVlxmpa8jlIKiaa2/lX3Lj0Ys+Hs9sXnPlMteNjNyCiW49NVYo8=@vger.kernel.org X-Gm-Message-State: AOJu0YxYjrx6OI0T6R8TX5yg5w/qTR1loB73bkzGTE1hJNWwyzsTpCXy DudY0XHSoG9pzFpENa7kF7Ez5vqW4afJi8XVH0PjNGgzmsJBWEDyxkU+ X-Gm-Gg: AR+sD13T8T/fGEvR8djcBlCuOSFYighdijBgekH7oxBmwg0yrWp+CXgeQlrez0JQb7r WEcYIuNQg8TG6BZLWU3G6bbVbDF1L85vJATAYmO9rtYzK003wAxcCsgLtMe6xQSmClqWr58v+FP FBbHL20yzLlNi4+EyvwR1BAvcOpuxkzez2Mdm8y7d3n6yR0ug7/YIuI8V8JMPgtoG3ViFz8IC0O zqZDT9qDNefUUDR0wF79BRplXzAifzsVSPMZE/GIYO8aIPHoDhZhur2diJh9Azyp1zSTDrldQTG IUOSLOUuIJq1iFiLbufe/JTv++PK50u2Tfi2omxExE3ylPVEEotes50BII0KhBQMljsbjHfonBt 3GrxdfGo7ogkgvxB57bV9H/O/Qmz8GNFh0fiJdQhW4qQjCiFCMa1tHZs0O09Y165QkKh5x8FNN4 I3vBiMPUGvrnYYg2XAt4iyUtHkR73fWRMKePwuVqToNs0kPIp22ZOgCQ== X-Received: by 2002:a05:6a00:300f:b0:84e:2bb:2d3e with SMTP id d2e1a72fcca58-84ee47e4825mr13869945b3a.9.1785845483364; Tue, 04 Aug 2026 05:11:23 -0700 (PDT) Received: from localhost ([172.216.252.8]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edc2d7c03sm5029337b3a.50.2026.08.04.05.11.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 05:11:22 -0700 (PDT) Date: Sat, 1 Aug 2026 00:23:07 +0300 From: Dan Carpenter To: Hungyu Lin Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] staging: rtl8723bs: clean up management transmit return values Message-ID: References: <20260731155228.22526-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260731155228.22526-1-dennylin0707@gmail.com> On Fri, Jul 31, 2026 at 03:52:25PM +0000, Hungyu Lin wrote: > This series continues the cleanup of management transmit return values > in the rtl8723bs driver. > > Patch 1 converts rtw_mgmt_xmitframe_coalesce() to return kernel-style > errno values. > > Patch 2 propagates the new return value convention through > rtw_hal_mgnt_xmit(). > > Patch 3 makes dump_mgntframe_and_wait() return void, since none of its > current callers use its return value. It still uses the return value > from rtw_hal_mgnt_xmit() internally to determine whether to wait for > completion. > > Changes in v2: > - Clarify commit messages based on review feedback. > - Make dump_mgntframe_and_wait() return void instead of converting it > to errno values. > > Hungyu Lin (3): > staging: rtl8723bs: convert mgmt xmit coalesce to errno > staging: rtl8723bs: propagate errno handling for mgmt xmit > staging: rtl8723bs: make dump_mgntframe_and_wait() return void Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter