The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Hans de Goede <hansg@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Andy Shevchenko <andy@kernel.org>,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] staging: media: atomisp: remove unused functions
Date: Thu, 23 Jul 2026 08:36:56 +0300	[thread overview]
Message-ID: <amGoePnbFT5LmbiZ@archlinux> (raw)
In-Reply-To: <CAHp75Vc-TaNLkQnck=OFonuWMWgdaxP+cVh7Oo+RjUeOWLfZEA@mail.gmail.com>

On Wed, Jul 22, 2026 at 08:08:38AM +0300, Andy Shevchenko wrote:
> On Wed, Jul 22, 2026 at 7:58 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Wed, Jul 22, 2026 at 12:42 AM Nikolay Kulikov <nikolayof23@gmail.com> wrote:
> > >
> > > This series removes functions in pci/hmm/ that are declared and defined
> > > but never called.
> >
> > Don't do it per file, squash these changes as it seems not so many of
> > them (I assume you checked the entire driver, right?).

Yes, the entire driver. I usually use 'git grep' from its root.

> 
> Note, if you want to make a useful contribution, try to clean up the
> below header
> 
> include / hmm / hmm_common.h
> 
> It has some ugly macros, instead this code should go to the users and
> then be propagated to each level and refactored.

I'll add this to v2.


Thanks,
Nikolay

> 
> -- 
> With Best Regards,
> Andy Shevchenko

      reply	other threads:[~2026-07-23  5:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 21:42 [PATCH 0/2] staging: media: atomisp: remove unused functions Nikolay Kulikov
2026-07-21 21:42 ` [PATCH 1/2] staging: media: atomisp: remove unused functions from hmm.c Nikolay Kulikov
2026-07-21 21:42 ` [PATCH 2/2] staging: media: atomisp: remove unused functions from hmm_bo.c Nikolay Kulikov
2026-07-22  4:58 ` [PATCH 0/2] staging: media: atomisp: remove unused functions Andy Shevchenko
2026-07-22  5:08   ` Andy Shevchenko
2026-07-23  5:36     ` Nikolay Kulikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amGoePnbFT5LmbiZ@archlinux \
    --to=nikolayof23@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox