From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D38EF284883 for ; Thu, 23 Jul 2026 14:33:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784817227; cv=none; b=jCrQIjzub1ir+yQ8roO0Ki/X1RE4AL1eGnK1Mc+JyrNE/64patlHR4dE2ufBRqtwMh4bV4n89brDflAk65lI1vFxnyxhFThPf8ekj2mGdehrYte/X4T+w+Epa+id8AgPRoYU5mEmjDkqiddLSQhoE0/iZi2t6DyAXPn3uxvmQVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784817227; c=relaxed/simple; bh=m9SnMkUX1tTQB6NO65dVN/roFkfDpAoBwsExIR6ZDZw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WldMQYvCoQOEvat4ajwJqKmEQtCbOLc/ySjh8TphJ/NwUOBe566CN+f1xGv2+NBmELKqTLmhgF8s41ghHZzyHk3dau0hUAhN/BJ9TDe9q6MwspxJiTX38iDwnNE8D2wsvh/rNODlYE9Pa7Cgx6TehwI/WLgAn/I+oULfVzg813Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QTKfXad+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UFIxQxKv; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QTKfXad+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UFIxQxKv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784817220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2njy+/zspbCzy0izhWL1wi7/dDBKbdf0HpY/B2TDfoY=; b=QTKfXad+ncfLcR+Xpvo+ysfguNhj/X2g05l+MNDXrRJMXlDikMVUxYRJVqZ7n6VPiQtHtT xhr9tZGJtEyNPSCaXh9/5EJxOUTjT2u76QHI1RSOsU5YZwddgSTtjegT7jLPEzLFWuhPoX 3wAZnFGIxdiN7iSqMS7HdHcPr4bY2aA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-1K7K64HOPk6mLwBOXhs_XQ-1; Thu, 23 Jul 2026 10:33:39 -0400 X-MC-Unique: 1K7K64HOPk6mLwBOXhs_XQ-1 X-Mimecast-MFC-AGG-ID: 1K7K64HOPk6mLwBOXhs_XQ_1784817218 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8eeba1d9e47so15707896d6.2 for ; Thu, 23 Jul 2026 07:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784817218; x=1785422018; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=2njy+/zspbCzy0izhWL1wi7/dDBKbdf0HpY/B2TDfoY=; b=UFIxQxKvshLj6Ov7uMzFME4atQc5u7W64zO12Z8b2SRYQgMB54b9cZIa1cXP7Chf9K IvCaj+TkG7B9r11P0iBmuo1iln8tHE+WwQA7OR96c2crMwBYnzLjANbUtbzDm6QXUFS5 duFfwKGT/0LhO1Jp+r3FFqqHfHoRFvrIPnuadW14Z9f1R3rfhGWVrlM84khYI8c3EfcF MapV7dKNfqR0qBN5ajsN2+6fhd9uxUVNbvczGZJpjJpk+P49VlByocb8B6FIHbXNnnmY zb4L16bMrHvqL58xQqpCBjGsyvsW1xWhN5GyS3IJwDcZY/c4GaEfZboMQVkNXmgGBJfS uieA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784817218; x=1785422018; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2njy+/zspbCzy0izhWL1wi7/dDBKbdf0HpY/B2TDfoY=; b=aLv/28xy3oDDduo1i7xXPFfxRcjvEND7NYcc289etlpV4uZrOaB0Nsf53ycri/V6aM GrXsPc7kR8damtAL9RLzk5L6Q4Oc6MeSjtLhv5Y+oM3DOyXUJxSDAZYqm9DRNdTGUl4b hrr8Y0MmlmctFdbD2Jhp2DoVpqpelccn0VAzg9V25Lv0aZWN7NnwK+uRkJgOkJXBPXsq Pw0niVjz0C660bvFZvoUsmfp1eViXMHiE74VHC/FiaaFYIwz/pu6Z0Odyp9YX6k8vzkH VYALaskQKIiy2xNItaOWq3Tu9yqDcdrhHwOMUr6s5nb88b4Hi2ju781/kY/Ztq5wgxle Volg== X-Forwarded-Encrypted: i=1; AHgh+Rq+QMgiE/xLoAv/s3nt9PYX238XtR/DLTImn4NVnZ91z05wvAfa1Q17HWS0Vy8UZI3ZjyYa2IIarHaGn6U=@vger.kernel.org X-Gm-Message-State: AOJu0YzMjezy6aILB6J89KRyvwCmacEC9re2N7P+4ahqYPP4BFy8qHjN 0mtcl5LcsZZ1lcTbhiz2syszttvWfyXo/BQCuKBxKtoE3B492dhxM7qJoZu5yBjXVeTM/RXrsMF vxeJyTpazniPYh7snWM35DgJrC1i5+NlM3FI6jTi6OWGz1hyGRox7bdZpiJsZI6C2GA== X-Gm-Gg: AR+sD12iZ4Ix0m0VUDH6SkXEi3YAeHJM59/bMz57M41xpim/OEZZFZJqv7rmVjmYFzQ oQ6ehX4/K8qKAj6PLKuT0Q/7h7W+GC5jpEFPnq17atrrWHa5gPeW29lBCiod1Xp/Ey4yI4yBbZR Ms+4I1S/NCRErJjGkwDv4Kk+juzKF7/1oNyQekV+0MxeESjZXmwy4UWi9FSVkuH1h9hmsAd8uIS fxHYqkdqeURo8fOdqo++fXhamVnhfY6ZwkLN9U2Vsp02BBYcGWFwdi1vArQDt3KBRAbjgGBf0yl fPMjvdurqK3MSj5PFUSf9h0ktcxDL78FYK+cCaMEUeeOfh2ZQgBLbuA7yCCkahMDRiwatSL8JbO g3EDdKY+5Pi34SfjfKHWlM9b7PfCawewq2u0= X-Received: by 2002:a05:6214:2aa5:b0:907:aec2:6cdf with SMTP id 6a1803df08f44-907ca363063mr40225826d6.8.1784817218101; Thu, 23 Jul 2026 07:33:38 -0700 (PDT) X-Received: by 2002:a05:6214:2aa5:b0:907:aec2:6cdf with SMTP id 6a1803df08f44-907ca363063mr40225316d6.8.1784817217491; Thu, 23 Jul 2026 07:33:37 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-907ba8b5f85sm46744846d6.2.2026.07.23.07.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 07:33:36 -0700 (PDT) Date: Thu, 23 Jul 2026 10:33:35 -0400 From: Brian Masney To: Jerome Brunet Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Michael Turquette , Stephen Boyd , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Tero Kristo , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] clk: clean-up simple provider misuse of the consumer API Message-ID: References: <20260723-clk-provider-simple-clean-v1-1-0c9668240467@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260723-clk-provider-simple-clean-v1-1-0c9668240467@baylibre.com> User-Agent: Mutt/2.4.0 (2026-06-19) On Thu, Jul 23, 2026 at 03:20:59PM +0200, Jerome Brunet wrote: > Clock provider should not be using the consumer interface. > In other words, a provider should not be dealing with struct clk. > > This change targets occurrences for which the provider uses the > consumer interface and corresponding clk_hw interface exist: > * __clk_get_name() -> clk_hw_get_name() > * __clk_is_enabled() -> clk_hw_is_enabled() > * clk_get_rate() -> clk_hw_get_rate() > > Signed-off-by: Jerome Brunet > --- > The change being very simple, I did not think it was necessary > to split it into multiple changes. If you prefer it to be split, > just let me know how. > --- > drivers/clk/mvebu/clk-cpu.c | 2 +- > drivers/clk/qcom/clk-hfpll.c | 4 ++-- > drivers/clk/qcom/clk-krait.c | 2 +- > drivers/clk/qcom/clk-rcg.c | 4 ++-- > drivers/clk/qcom/clk-rcg2.c | 2 +- > drivers/clk/renesas/r9a06g032-clocks.c | 2 +- > drivers/clk/rockchip/clk-pll.c | 24 ++++++++++++------------ > drivers/clk/st/clkgen-pll.c | 20 ++++++++++---------- > drivers/clk/tegra/clk-tegra210.c | 2 +- > drivers/clk/ti/clockdomain.c | 2 +- > 10 files changed, 32 insertions(+), 32 deletions(-) This looks good to me however can you split this up by clk subsystem at the very least so that the various submaintainers can pick up these up? With that: Reviewed-by: Brian Masney