From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDE74368D5F for ; Fri, 24 Jul 2026 05:19:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784870383; cv=none; b=USr2Sjby7T3/+Q6nraHxYXIBCEzZ0d+NH5rjDW7Lv+rFHbWljmt/N+9DZXddqaopnbYaqpPsltv/JgmezddDon6xi6wVFylvsSV6NxIh3YHCjA1hoae/dSUdwrQTal4IRyyaAH6XSgvxElcSeRHOk4kR3aeyNY4qSF5T/b3tp3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784870383; c=relaxed/simple; bh=rAeDwFHAlpP+kf6lVb+g3u+SaL6AUhIvbglwFHo9Axk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FdH8eW/gOei40qM7+39Atm/sLM8sUxeNbvzMMRqq+NoAJrIedQPJc9iSMxnZ2B7OyNOExkEaDoDBOflsm8kfWOZYpDeu4A4uC8kUFSq7RLnYmqhAF6+lWEcF1nu16viugnSf/KREgjsEGHkB/M0NGKmLN7GYT4Rleqe+QeKYNIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=OPcZ48ZF; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OPcZ48ZF" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2caced6038eso616865ad.0 for ; Thu, 23 Jul 2026 22:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784870381; x=1785475181; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=dpBzpVbyjq3irNQ8NZt+4MS84b8k4vNA2XPSiTe8b48=; b=OPcZ48ZFQWBEp/YAQvvFF4TlFTiNihg1F2oKxzYjP1ZkcLa34pMQX0PICaibDLEMbA 51qyt5GVEEb9wj70NVZhK0VgxKnxdEMdH27rxsEIQstlgYBnyATW/07MC2kHDqSSc/qQ RFIkmnRmyRevCCgvpgNK4LHFaeVf+mGxwZ4V8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784870381; x=1785475181; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dpBzpVbyjq3irNQ8NZt+4MS84b8k4vNA2XPSiTe8b48=; b=ecYThPQcr6eVoBLK6Lf3tg0oydVMiTwW68/iBBNjr3vU/94OUzYOdb4otIz1aCDzvc wNUKW+5PM+aRJY4yFFlyFsPPp07IkY5TAP72nKFHM0JZ/Pbdups9g5WLurMuJb7GHo6m ZoSUX74Qkd/hGiqKbUCEuKI80QveXXyLjA9dN7GPniIr5JUye+ak/8L29fJDng+a3Y+P E2XQTafB++7m+WU/mK4iORoNMbNT8/HR8ZimceG1N1VS8QON69FBieEg6oj9fEnKpsM4 zK4jdFuuTm+w0MxsUxHFDhWQazK2Ytg7ew9aK7lmdBieTAzXWB4k2sWBD1rwcuBjzSf9 ex6Q== X-Forwarded-Encrypted: i=1; AHgh+RpRY+wu6RED/pvaX95ZsHkj6erfJtEbbR0Qwu+mrR4N7rI/scmZt9CsvaJM+fk2u2UE6zsBJwJYGrPOWd4=@vger.kernel.org X-Gm-Message-State: AOJu0YxnSVrUAvYghYE1a8f/zKdUkCbaxsG6OuF88NnloETVWFVu4NWb euf5kt4rGIwWeUvO9w4etY9Jp3IqxWArgBHZw+8a0Lx7jGC5fYErxAFl4CPxk1kQbw== X-Gm-Gg: AR+sD11fWmtFl87YzKLtma4Cu8m2GVqPvEYwxzrHn69GCbiCcmBpTX5K3tE+zYC/WGh rfNuERhdtx2SxF2ng2vUayslZe83O+/oeKMkbNb+UugTiuWlHjCCIV7nNiSM6apt3qMjysdGtts goMWYR+Q4kLQgpK5ShUhtzYrM9Q6twSzq2f9LjSxstMTRo7N7jkFiALFskmtZr1p/2RqXvUUgke +YZn0FdXBFwA0zTm3KCHDDLtjSNr1ipGvCSHeTwlHQdGv9QNa05zhi6vrVCh6zPrKYQd4IvYsgZ K5PbI4vPghCcdwYd/ZE/n13oo4hYegbRg5VfUk6dC68uz4uzOgknP0SKT7zntpeWDloMsaFWdEt 3NZ6QsWJoOAW0nRyUX7xtcL42q7KqCdPylMI+gumwjjBPcA2Rgo/NyXj0YwP5kSmYtQpcjF4fAg RfbJ/9CgMN0PZPWZECmcDdvhzbXEN2w94jffxaNYKckw== X-Received: by 2002:a17:902:f682:b0:2ca:2390:ff13 with SMTP id d9443c01a7336-2cfa9430714mr65536685ad.5.1784870381310; Thu, 23 Jul 2026 22:19:41 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:c102:f12d:5168:6be5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f2e5ee6sm45222155ad.53.2026.07.23.22.19.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 22:19:40 -0700 (PDT) Date: Fri, 24 Jul 2026 14:19:37 +0900 From: Sergey Senozhatsky To: Haoqin Huang Cc: minchan@kernel.org, senozhatsky@chromium.org, axboe@kernel.dk, terrelln@fb.com, dsterba@suse.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, rongwei.wrw@gmail.com, Haoqin Huang , Rongwei Wang Subject: Re: [PATCH 3/3] zram: reset per-priority params when changing algorithm before init Message-ID: References: <20260627070216.13511-1-haoqinhuang7@gmail.com> <20260627070216.13511-3-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260627070216.13511-3-haoqinhuang7@gmail.com> On (26/06/27 15:02), Haoqin Huang wrote: > Parameters validated against one algorithm may be invalid for another > (e.g. lz4 accepts level=65535 but zstd does not). Although algorithm > changes are blocked after disksize is set, they are allowed before > device initialization. Reset per-priority params on algorithm change > so that stale parameters do not silently carry over. > > Signed-off-by: Haoqin Huang > Reviewed-by: Rongwei Wang I suppose we can do that. 99% (if not 100%) of zram setup routines are completely automatic (systemd, mmd, .etc) but why not. Reviewed-by: Sergey Senozhatsky