From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B76C03A9639 for ; Fri, 24 Jul 2026 07:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784879901; cv=none; b=HCctywYcbr6KgzWRNK+W6VtUqxi8jxiDVd+BDUUl8W1l3FBatVdlS6/aUpfjyj+m8HWPeljJ9IJFpe3WBIm/IzyaxVAQW2f0OP5O2ucop8nTL2uaDnT5aaQZqpL5aRtIQ7UtnfyKhVs/RutvOOUJS53udPWUMFppadowkCP12BE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784879901; c=relaxed/simple; bh=bogGGtQaoIfpptMv/5EHfOl6de0VSi5cFRCgLBKsi94=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ul9sWns7F8DSW0eC/d6aTOwsEvHTsRuqjOUkQD24fP6wb5OB15N/9pPaDEHKRcFvE+js/MJ0ja3/wUWVSy359V4cPgpur5pZAyRY2e8nF+k5wBYWhyiyLijo5o19TE4r2tA9ZDCtyT0fI0UtZV2Ip8b4K/jOrMbQpY2ZQ+nYLBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=c9dn0+QA; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="c9dn0+QA" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-47f633e6058so152030f8f.0 for ; Fri, 24 Jul 2026 00:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784879897; x=1785484697; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=GcW7bFGtTMZkLrtmmnJtMoZJkBsJXN3gnYt3y6BzEk0=; b=c9dn0+QASAn1c8Cg1L+nucUvacCwgGA3jI9sPF+I1klj93QcDDMobjwGs4Z7DVgsSO wdwAoA3MweiXT3fT4ABBjpiiTBnArTxV60QYJbj9VUkEULdrEwgux2kmqT0+v2fGP9Fj pzGMeFcV+tuqYqxg6u9oeMe+h5/BNwcFvcaXLs8MXGygiRQ+c+UJD8GVzqW3CnkJV7Jr nJtBDMzDlfNCwP6qeFNuyh3iiBTGRVbrRWStCCRSPZzk0ePjibdNtGa5uZDGVRItgyk7 g+tHmGivz0eq6SaFvXPjdy4HygBl1pJ4LvSz8SaBXLR7MpdEIQCg+7oiQT4wxIp7scv1 X5Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784879897; x=1785484697; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GcW7bFGtTMZkLrtmmnJtMoZJkBsJXN3gnYt3y6BzEk0=; b=IgwOHotQN/e4qu3gDuLUZHUWs3gpT9MdqRx7xvbfPCn69v20biefX6HmoldqAIIm+/ uwUVXQp7diUDzeH7F9ZMhr1DKDmfsXrAlq6Oa9EwdVYdT9pNFNAuPuKnMW2xsi8A2mCu O6iagS2a7dRoxadJNYF6QZ6zoy6pyMuJpvHiB9GvfFctlJKItWn2DS2VRig47kjeLUPg 2vV3drW0QXWtDsByGTo1Qx6uS8LaEGoYjS/IH7Sw+N0+H7Mp7JWA+oCLI1Tl/4pdwj48 wi8fCX1hDzd1I2ckENc9SG3PI/8rmh/XTLX0sByqqykOCyZzs6GVcxdIZtyAdGjIDh0r 2gPw== X-Forwarded-Encrypted: i=1; AHgh+RoGMZO6diNjTl+aASV59kQsSAz35TbazblUZTc1aOi/1svYc5fRfCFGofMhjr0yBZJZY0FhfGabp3uAc6Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxWIF8jOddTmWjk9c4YWPTdWbmrRKMoZOWEuo73pdQ6wGO6Rl2j 5vpX+tB5J1s7gO2ToD+Bg0N1pYa5Skxr8BjbBxlKbz/3ij4TTz2jJWgtW7PGWPn0FvYKUx4Ig6f cywsf X-Gm-Gg: AR+sD12dVQimjHwEgLIVcE54TEl9YaXfbeFcP2CRYmQIC8cAew5xVw/ckWxG+ykhPG0 raZ0iwWLEwo9aYZI+wfHd6uRKCdMQT5r7ORDzrXBA/3m5uMx1dZGLWcZuWjVouCiIGtf5+70KAo VsCifWbBsg1GC4xQsVeRjWI/verOh/XVsHES56/7kB+W6Pe2EQpsVyhxrC0wuILgF41txkCMmvx LXi5BrnqmaWpWUm0RphI7S8GBXXUKUqWtexhJlEY92VxmkRP4VewTL9DRtoz/gwByxpYE9vpBK2 GBgCuiSCIfsd0Emq2Cqk/cBFOsABggt814kpoOS061A4gRppgXXGStZRE8qE/q68dvV+HBAKRWo /kw0lRSjwg6zj79DfcVD9/xOzW3+jQ/X492bu7uv8alDEEYosbiKY5/tnCsPCZwl01f3t6sI3fy XEQ4vQnVLIwWGOk7B7kw== X-Received: by 2002:a05:6000:46d4:b0:47f:93b9:b76c with SMTP id ffacd0b85a97d-47f93b9b770mr3298489f8f.56.1784879896803; Fri, 24 Jul 2026 00:58:16 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47f85c52fc0sm21909641f8f.23.2026.07.24.00.58.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 00:58:15 -0700 (PDT) Date: Fri, 24 Jul 2026 09:58:13 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Hugo Villeneuve Cc: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Hugo Villeneuve , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] serial: 8250_hub6: Fix double definition for hub6_match_port() Message-ID: References: <20260720080812.1223096-2-u.kleine-koenig@baylibre.com> <20260720100708.5b9b3ed9f6f42b27adb264d4@hugovil.com> <20260720185326.9652faa0df7b02e07eeb7d4b@hugovil.com> <20260723231359.5d7fa1e8e11990fa00c476f4@hugovil.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ufnmj4vyuobnzfpc" Content-Disposition: inline In-Reply-To: <20260723231359.5d7fa1e8e11990fa00c476f4@hugovil.com> --ufnmj4vyuobnzfpc Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] serial: 8250_hub6: Fix double definition for hub6_match_port() MIME-Version: 1.0 On Thu, Jul 23, 2026 at 11:13:59PM -0400, Hugo Villeneuve wrote: > > For me the open question remains if the driver works in the > > configuration CONFIG_SERIAL_8250=3Dy (and thus CONFIG_SERIAL_CORE=3Dy) + > > CONFIG_SERIAL_8250_HUB6=3Dm. In this case at least commit > > 3d406299d8829747fe2e8692f4c29fe3dc1d101f + > > https://lore.kernel.org/linux-serial/20260715153707.4181828-1-hugo@hugo= vil.com/ > > introduces a logical change in uart_match_port() that isn't explained in > > the commit log. >=20 > Not sure what you mean by that logical change? With said configuration and before 3d406299d8829747fe2e8692f4c29fe3dc1d101f uart_match_port() returned port1->iobase =3D=3D port2->iobase && port1->hub6 =3D=3D port2->hub6 and with 3d406299d8829747fe2e8692f4c29fe3dc1d101f (and your fix on top) it returns false (because when drivers/tty/serial/serial_core.c is compiled IS_REACHABLE(CONFIG_SERIAL_8250_HUB6) evaluates to false). Best regards Uwe --ufnmj4vyuobnzfpc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpjGxMACgkQj4D7WH0S /k6pyggAmd1KCtnMBdIxWMNBg1jDsLHqgkhcGyMi0G9P8cEgODx4GEK0T/LaS0YN stJUZ7lhJ9PABB5L7DhKmZu+DrpOS6Fg1LHWO0LamkLr/5DwJb2rZt1sfCxugX/y sn15gau6oym4zexW5JhBwUREXh/ByETbo0WIa+WVoom9jPyP5YJ2jRyiMyoDi0HQ 1hzmvxEUzmktKdN4LPTvZv3AhsKhozt2pd48lKexcDAJ2ftv6EinumgbNkQRKdbb M5Pcb/ItySsO+RsK2eeOG56fI3ygHmIVip34Gt6Sa4E1/t4kKOmJpbrRuROPwc3f VohXuUGdiiDImUdq7H8TJZkiWRdugg== =fnpQ -----END PGP SIGNATURE----- --ufnmj4vyuobnzfpc--