From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8C313CC7C5 for ; Fri, 24 Jul 2026 08:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784881512; cv=fail; b=CEOZuK1qtM1QMk2Kp2k5KF95QjADEjrsuh9LTUzc+x5Y8cFHYRzHJX8CZAtvvplZRGjpYCN3BcZs9kiitT9z+o9HdIm3vHFypLUgmymoWjjFG9rhy9+xh1qXyz4tVMFW5o63yJF6fx2NnpA4nz0E99fc4mNj8UcCrhwWBnbg7NA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784881512; c=relaxed/simple; bh=jtUeW+1EOke4106PPKzbGsPUHWkvvov2CPlel6+Y3Zk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NVvbrTIS58f6xWOrFHEKY0VkJG4zOKcWsEJt28GwkUVzsWq+eGH2TJsc9zENcKRTegs6p6NXRdv3vCZDQHoEMKPa+19gZnLv2Eg7aFdPQJIN8y5zqKgS53ch3y3nL0sb4onxpfrxXLbYSEA6uhMjZ8npqXQmxM0+13K5+hGp2C4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=DPrK+CTu; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=zlw/I2zx; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="DPrK+CTu"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="zlw/I2zx" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66O66xlB599892; Fri, 24 Jul 2026 03:25:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=PODMain02222019; bh=8/MSImSRrH4EI85fZI gg1hS6NAx73gx05vCfPfCqZY8=; b=DPrK+CTuhT3H5gO8Pts0lNkVesw8PopMYy dliK5at9Tq4yzeTiLF/8CVcky5PmS7L5Db7rBLx/lnjMWAdU88K1nkD0mhFRQM2L h7gSXVUGbzFccsCc0n0wJNeYpCJNw7CvAsNDuuhIXrkLq2/2Q9Sw8GI5atN24kWs WWMFe1PS66FvlvqPouyRbipolxykqps3Xp0cTTMCfCKqTq59dFFyRrpaKUhR4b68 VfyNmLBMiFV3xxgWeoP1ju2hzgl/6jAvh3UVH6bG/eO1V2qFv4GibRqoYwfbQiip L9bFdnXFWVxckvlC4Npjpxh2YlwIAWYkjk9uGEKOY+zE4XtGVPSg== Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11022128.outbound.protection.outlook.com [52.101.48.128]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4fg6vyrghd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 24 Jul 2026 03:25:04 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dBIXM6CwU7/9+XVBQSaN0nMv2ZuU31iNluze21H/la6zPp3K4ngkOGC1u7lUlcX4URFICihFDPI+sWZitxKAI2egXK5ZZJMyWt6aZuMWCSni9QVsHPPHXt+YBoeJEycNrE7hH4urYBnJ/I8A0lCw8dyr8mTsGVkIK+C4+Kj0P3N3XDEMasKqFVUGkUGObybuQ4SPUr9GdMeiydS6iUgyuxzx2SdCylKeKjWunhtiRz39Oo6l30O7DrGZOe3hlPcCVcbz8YplrmuMDog9IvD9XGCOvTqAArwHj7HxTeneZzvSUxvhw2v3ouLw38M263REQRiU+RwQwLaxwrmY/edgew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8/MSImSRrH4EI85fZIgg1hS6NAx73gx05vCfPfCqZY8=; b=NU0goi8isqRPgDRgNlQ31gW0f4Bmwph1tuQyVKv8PWo2w5GTuqUCsTnqeKJDJzVD9NrbXh5QsG2/E7Mx9fTsao2+1SNOd/8EqUcC3o+DwftEN8GIkxgYHq7vyS6hneEIPkyXGPCI528WxUIc97EftBrBrRJqdD6CTqB34P4n450eSGcaJUh5pfzKU6ltmXEslZf6Dw6oBXjcx4VdqQDEPVPzjFXfnu35jyUFy5Ply0C1lom7H5/mnE0laPCdlXvjXrO6Sr0211LwIWGOjYescvDHmGmziMQcNPsMU8xrNZ3OZqmtzFqpCbIt4jWVBA9ycv9qYJkAWQQMFm+ONDBPLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8/MSImSRrH4EI85fZIgg1hS6NAx73gx05vCfPfCqZY8=; b=zlw/I2zxzen8N4IZTDZJuCl6OjzTOdgzA/8srm2jqCo6uGuXuUGTFAES5y5ugFUe26qJsP7P87rzPr9W1gXNLoTIIGTYaJ71ctjhaQVGW0Yjieb/UYRgeqh2vOCt022W9wDhzRDuHrr6ty6MxPAq3LkPFxY4tRux2ytK+fm3ImI= Received: from SN7PR04CA0181.namprd04.prod.outlook.com (2603:10b6:806:126::6) by PH7PR19MB7028.namprd19.prod.outlook.com (2603:10b6:510:207::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.11; Fri, 24 Jul 2026 08:24:59 +0000 Received: from SA2PEPF00003AE5.namprd02.prod.outlook.com (2603:10b6:806:126:cafe::2e) by SN7PR04CA0181.outlook.office365.com (2603:10b6:806:126::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.12 via Frontend Transport; Fri, 24 Jul 2026 08:24:59 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SA2PEPF00003AE5.mail.protection.outlook.com (10.167.248.5) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Fri, 24 Jul 2026 08:24:58 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 30DB6406541; Fri, 24 Jul 2026 08:24:57 +0000 (UTC) Received: from opensource.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 1904182025A; Fri, 24 Jul 2026 08:24:57 +0000 (UTC) Date: Fri, 24 Jul 2026 09:24:55 +0100 From: Charles Keepax To: Sang-Heon Jeon Cc: Julia.Lawall@inria.fr, Liam Girdwood , Mark Brown , cocci@inria.fr, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH 28/36] regulator: wm831x-isink: remove conditional return with no effect Message-ID: References: <20260723184538.3888637-1-ekffu200098@gmail.com> <20260723184538.3888637-29-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260723184538.3888637-29-ekffu200098@gmail.com> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003AE5:EE_|PH7PR19MB7028:EE_ X-MS-Office365-Filtering-Correlation-Id: b743c71a-e87a-4033-34e2-08dee95d0ca9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|61400799027|23010399003|82310400026|376014|56012099006|10067099003|16102099003|22082099003|18002099003|4143699003|11063799006; X-Microsoft-Antispam-Message-Info: v39Cn2tJvVpPJ8no7IV/Fe0kUe9PKb6IR8JvzLtuMrWtkWqVvRsKX495SFykAlYQVe5rSYenC39P5fQd6uOgScJMCu191UDbXaGQr96JNZUdyxau2jluWXuGXQD82PShZ0+IHGe9r/AnVJIIRDWwMckNRkl5XwGyAzmsuvHEPCHUAFjRKWgPla5W6Z3LS3PTfyVL+21Lq6HlTrBz0Hogi60H8DQJb353llmvxMkF3zYkwiBpMN0jmsmF6TJb/5+vOPPKof+fU9XO+0HUxDlh1OXRy9Nng5ijO14SYGYobEtk88YKOK6VF6j6ajnJGkI7lVMzoEmp+2o5AtZ+cIQSQ98Of2yBGvsk5ixFg+L7XwWxyLTDcC5FS1nbmN7MdNhcB+QrBKKqlOYbrnxw+EVy6CcB0GFx3D5ojvtfiVs2HcoAzmpD+E7BZqbu8NDRtRIFWDGf2DbddLqZC3YS9eubd2snOfwXfoKqLO69VelcjDRKccBYekfPIYPbuOP47wCQVotLsTnStTV00LlxR8Gc3/HSXwMqKYyErE7djpFZS4Kqv/KUHjz8kzW0z+GeflGS2q+YTMrYI1LO1M7mB9SpXxrrP05A7Ux83Uhtih6DUhduw/zmVPGJaeiRv9TVbHkEpTyhDi7gi7/rLjiT+FVGx6Zov6dA00TwdoqxpVpQfBSzNhKvliU79MjV2gp8LpgtCyljjOcpl4HCh3JpOSnGFw== X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(61400799027)(23010399003)(82310400026)(376014)(56012099006)(10067099003)(16102099003)(22082099003)(18002099003)(4143699003)(11063799006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7Z0Ml0H/NhPhSbNFMGyogzV6hQVfnATuQkz2G4dqZpliVSyahahociXADEOXMx8pP9x7r/5oY5jB3O9xrcDZvZNdVc3DphiWwwrlFk62BkOm/WsLJg5IC7hFJLnBONZN2ghjKuddhTjAZI++LlHWmSrxoVlqYc/ikRZX7ME2mhtPOhdC/DteaZcK1bwP1W/zbw/xU7F6e4rDNx7aow5MAfEYUfarG49CxzqXJPZ4/5oKqnRC+AGA7ZJDpotPfTzzBna4BeCaP9LvYvxBOMd4cF5PAQumga/CoJipm0uLZkCE4siSDmxFvd48lCBb6pPyvhQMgFjvoviCdgB/5wmfTQOin/Fbv1X3qzW7T0LI6ac5YDJD2k+jK9akgZWe8TDbAORlOfoP/QbwCy5zxxDq7+w98qR/42NO9QZLW9Rki2MKS/NIiso5zIB6DMiuH0Af X-Exchange-RoutingPolicyChecked: P+tXZLCVt9+Mfiav+wFJZNXgGLaQsFuAPHuNFE6VYg6js2DCLEHnnlhcXqS2r2EuvXuRaMjzS8hTtrRczW92BVaMAk4EqIZ/0eFST1j+a9alx+BvZ6koK0aWM9EumsKmkGzptsjgIj0mN6p4GZnAnzerb84BnkvrmgH+pIdWgZtmVFWW5s5ZkeurT2VaG+ebIm9p047yKqzgaVF08rqxKbIJqbW4aSNlAWwL77fibg+i8uVBJ3pMBewKIoAXMMvnK8VOmwjjZUa0063Cz2cEYjWhvMjMk+Mc3BAa5Eey/4YdthRpu1E0W5pvGclyCt7KLkhP11cJcX2QRwNqsFdFFA== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 08:24:58.4075 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b743c71a-e87a-4033-34e2-08dee95d0ca9 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SA2PEPF00003AE5.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR19MB7028 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDA3NiBTYWx0ZWRfX9Uhtohb3Mu3+ T0TevRUb++ba27qTf53zE2mCWdIhTOqU4iu0Xn9vv7oizh0GKXouH1KQI+fOcGQ/jYSs3BXGjAE vfx5mFB6B536pNt5QFj6wU2eWF3VauI= X-Authority-Analysis: v=2.4 cv=f5l4wuyM c=1 sm=1 tr=0 ts=6a632160 cx=c_pps a=YH7lkWZYaMs4szCCOGs1MA==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=pGLkceISAAAA:8 a=w1d2syhTAAAA:8 a=4jFb2WNxUpIEj7qyoYMA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDA3NiBTYWx0ZWRfX/MOHt0FRSRyH lOUmhNF8MLRxqrgtLzWuj5lV/sCXWYV34pLgZ6JMGTdtvkNRo0wwQ5iwZJ2IQaGHothSo8QUvQG HNYMSOjceH8+btMqBfvJq3rvvowupMWZq4Jp6u86MaoZCrdD3oPG3jfL9Ur9SGgWr+EZ/TDt1S+ PYrfv5iPYT+Q2hOn7NBHBsoCgCpSfy8buW476ejBcgkITCUXX60rao1dJpYufTE68i9CAW4yCWK vjXGeB3iEQAA3bHY0GXkXS1g0AQchh1ogo96NuT8M3X2HVbRgxSvo60jlnK2/5dRPq/VJivpm8o tAdUCfIpu5bbQSMguPN4Mu8xZZXi0+iIyhg/R3nTA5Qgn1Jbyym6D5yydKL5fjR97qhd3BTijlS 5M9jYT07gNPB96I7vy+KYV97c7GsAbE2DenoBOYTf2V9FUUnKkYHbHl+uSCieujbPBLQzQFVigN ea3B8o9r+/CM4pzOMcQ== X-Proofpoint-ORIG-GUID: -tw-cdR4bcN4noYlb2EMR-XzCvitaYky X-Proofpoint-GUID: -tw-cdR4bcN4noYlb2EMR-XzCvitaYky X-Proofpoint-Spam-Reason: safe On Fri, Jul 24, 2026 at 03:45:30AM +0900, Sang-Heon Jeon wrote: > Both branches of the check return the same value, so the check has > no effect. Remove it and return the value directly. > > This is the result of running the Coccinelle script from > scripts/coccinelle/misc/cond_return_no_effect.cocci. > > Signed-off-by: Sang-Heon Jeon > --- Reviewed-by: Charles Keepax Thanks, Charles